search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.43k stars 1.27k forks source link

SB3 trying to adjust tempo range produces an error #13186

Open C0D3-M4513R opened 5 months ago

C0D3-M4513R commented 5 months ago

Bug Description

When I try to adjust the tempo range via the controller, the following error occurrs: AppData/Local/Mixxx/controllers/Pioneer-DDJ-SB3-scripts.js:784: TypeError: Property 'skipSoftTakeover' of object [object Object] is not a function (using changes of https://github.com/mixxxdj/mixxx/pull/11307, for the vinyl mode fixes)

Version

2.4.0

OS

Windows 10

Swiftb0y commented 5 months ago

Thank you for filling this bug. I can confirm this in indeed an issue. In the meantime, you can work around it by removing the offending line: https://github.com/mixxxdj/mixxx/blob/96a03e82c1dfbbb9f37294a540b5ca4454e1fbb8/res/controllers/Pioneer-DDJ-SB3-scripts.js#L788-L790 @jevilalta skipSoftTakeover never existed. Can you elaborate on what you wanted to achieve here? I assume you wanted to enable softtakeover for the tempo fader, now that its physical position doesn't match its value anymore (since this getting activated by pressing the tempo-range button).