search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.44k stars 1.27k forks source link

Track/BPM: add `bpmlock` control #13199

Closed ronso0 closed 5 months ago

ronso0 commented 5 months ago

This replaces recently introduced bpm_toggle_lock with bpmlock. Benefit is that we can now bind GUI controls also for feedback, e.g. have a BPM lock toggle and block/disable beatgrid controls if BPM are locked.

The pushbutton only triggers the un/locking in Track, CO is updated by track signal.

ronso0 commented 5 months ago

I think I / we missed the opportunity to make full use of this new control in #13041, so in order to not have to break mappings later on I highly recommend to add this to 2.5-beta.

ronso0 commented 5 months ago

Thanks for the quick review!

Nite to myself: document CO

ronso0 commented 5 months ago

I forgot to change the ControlPickerMenu, too. Just pushed the fix directly d59eda694b7292782569195547c46e76bf01e91d

ronso0 commented 5 months ago

@FrankwaP I hope you noticed this fixup?

FrankwaP commented 4 months ago

@ronso0 Thank you for the ping as I might have missed this update!