After accidentally enabling clang-analyzer-optin.cplusplus.VirtualCall I noticed there were a bunch of virtual calls in destructors (for example cleanup() in Analyzer, ControllerScriptEngineBase::shutdown(), also for constructors ControllerScriptEngineBase::initialize()) that can result in UB. We should fix that. See https://github.com/Samsung/GearVRf/issues/1567 for a good indepth explanation of the issue.
After accidentally enabling
clang-analyzer-optin.cplusplus.VirtualCallI noticed there were a bunch of virtual calls in destructors (for examplecleanup()inAnalyzer,ControllerScriptEngineBase::shutdown(), also for constructorsControllerScriptEngineBase::initialize()) that can result in UB. We should fix that. See https://github.com/Samsung/GearVRf/issues/1567 for a good indepth explanation of the issue.