Open acolombier opened 1 month ago
@Swiftb0y let me know if you would like me to take a look at this if you are happy with doing the clean up yourself
I'm currently ringing for time a little so I don't know if I have the time. I'll try to whip up something later today, If not feel free to take over.
@acolombier so I spent the day and came up with https://github.com/Swiftb0y/mixxx/tree/refactor/gh13245-waveform-factory%26prefs (doesn't fully build; also currently segfaults on teardown because of https://github.com/mixxxdj/mixxx/commit/424b1c96bff4808fe0d073eeb045115ca5fa911c which I haven't found the time to dig into). I'll try to finish that tomorrow.
Great! Thanks for your effort.
WaveformWidgetFactory::findHandle*
const
and use something likeWaveformWidgetFactory::create[*]Waveform
with smart pointersUserConfig
functions whenever applicable and replace verboseset
orget
withsetValue
orgetValue
WaveformWidgetAbstractHandle
and aim to remove it if possiblesrc/waveform/widgets/waveformwidgettype.h
to adopt a similar style than in #12798This is a dependency for #13226