search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.25k stars 1.24k forks source link

Fix/gh12894 single quote sqlite string literals #13257

Closed Swiftb0y closed 1 month ago

Swiftb0y commented 1 month ago

Alternative to #13247 along with some manual follow up trying to replace these literals in our query-strings as well. Also based on 2.4 instead of main (as #13247 currently is). I'd appreciate if someone could double check if I've missed any string.

saper commented 1 month ago

I've found only those two so far, but I haven't reviewed everything yet.

daschuer commented 1 month ago

@Swiftb0y Can you confirm that https://github.com/mixxxdj/mixxx/pull/13247 is now the base of this PR? In that case I would prefer to merge both and rebase this one onto the original. This way we get around of the formal author/reviewer swap in this PR. Is this OK?

Swiftb0y commented 1 month ago

@Swiftb0y Can you confirm that https://github.com/mixxxdj/mixxx/pull/13247 is now the base of this PR?

Yes.

In that case I would prefer to merge both and rebase this one onto the original. This way we get around of the formal author/reviewer swap in this PR. Is this OK?

Yes.

Swiftb0y commented 1 month ago

rebased. please review.

JoergAtGithub commented 1 month ago

LGTM! Thank you!

Swiftb0y commented 1 month ago

Thank you