mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.25k stars 1.24k forks source link

Effects Routing: Echo cuts off when Unassigning Effect Unit from Deck #13260

Open ZenKyma opened 1 month ago

ZenKyma commented 1 month ago

Bug Description

When playing a single deck, I often build up tension with the Echo Effect before a drop and let the feedback fade out from the buffer after the drop. My first impulse was to use the deck's Assign Effect Unit FX1/FX2 button to cut the signal input to the Echo buffer, but then the Echo Effect immediately stops processing.

Current workaround

One could achieve the desired fade out by turning down the Send knob of the Echo, but the problem is that this knob is not always immediately available when using meta-knobs mainly. Furthermore the Send knob does not differentiate between input sources, while they can be easily controllable with the FX1/FX2 buttons. This could allow letting one track fade out while keeping input steady for a second track.

Expected behaviour

The expected behaviour of the Assign Effect Unit FX1/FX2 buttons is to cut the input signal to the effect processors, but not to interfere with effect signal output. The Enable Effect buttons provide this functionality already, if one wishes to disable the effect.

Motivation

Allowing unassigned effect units to continue processing and outputting buffered signals would allow for a more versatile usage of effects and correspond better to the expectations of DJs starting off with Mixxx.

Version

2.4.1

OS

Linux x86_64

Sidenote: The behaviour described in #11385 (possibly related) could not be confirmed, even with a second dummy track the effect output suddenly cuts off.