Enabling/disabling time/beats to next marker, then hitting Cancel; still saves change

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.

http://mixxx.org

Other

4.52k stars 1.28k forks source link

Enabling/disabling time/beats to next marker, then hitting Cancel; still saves change #13264

Open mxmilkiib opened 5 months ago

mxmilkiib commented 5 months ago

Bug Description

Re #12994

I'm under the impression that, if one changes a setting in the Preferencer, but then clicks Cancel, then that change is discarded and the config should be the same as before that change was made.

Enabling the time and/or beats until the next marker feature then clicking cancel does not do this, leaving the change intact, which undermines the point of having a Cancel button.

Version

2.4-alpha-1795-gd6ca42edbe (main)

OS

No response

ronso0 commented 5 months ago

one aspcet of #7440

related /dupe: #9745

ronso0 commented 5 months ago

This instant apply / live preview feature for the scrolling waveforms is actually nice. We may store the previous state (all controls in that page!) in slotUpdate() and restore them in slotCancel().