search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.25k stars 1.24k forks source link

Revert "Handle not supported files when dragging to waveforms and spinnies" #13271

Closed ywwg closed 1 month ago

ywwg commented 1 month ago

Reverts mixxxdj/mixxx#13208

Tested manually, this fixes waveform drag breakage

acolombier commented 1 month ago

Looks like merging this would un-fix #13206. Looking at the code change, the bug appears to be fairly trivial to fix. Shall we consider fixing it instead of reverting entirely?

ywwg commented 1 month ago

My preference when there is a breakage is to revert first and then work on a corrected fix, rather than try to "fix forward"

(example reasoning: https://www.linkedin.com/pulse/service-recovery-rolling-back-vs-forward-fixing-mohamed-el-geish)

ywwg commented 1 month ago

too often, what seems to be a simple fix on top of a breakage ends up making the situation worse, and then you have to fix on top of that.... unless the cost of rolling back is huge, it's best to do that first.

daschuer commented 1 month ago

@acolombier If you have a fix under your thumb, we may test it and decide. Both are easy to test IMHO.

acolombier commented 1 month ago

I don't yet, but might be able to get one together later today. Happy with the revert so this isn't a blocker

ywwg commented 1 month ago

can someone approve so we can fix the 2.4 branch then?

Swiftb0y commented 1 month ago

fyi @ywwg it seems like you're pushing your personal branches upstream. Check your get config please.

daschuer commented 1 month ago

The fix is here: https://github.com/mixxxdj/mixxx/pull/13275