search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.25k stars 1.24k forks source link

allow changing the waveform overview type without reloading the skin #13273

Closed ronso0 closed 2 weeks ago

ronso0 commented 1 month ago

... by moving the RGB/LMH/HSV pixmap drawing into the base class WOveriew. Type change is caught by a ControlProxy.

Switching works super smooth :sunglasses:

Partially fixes #9745 This is a bugfix IMO and can slip in 2.5 anytime.

Nice to have: enum for overview type

Hopefully not to many conflicts with the current waveform pref work

ronso0 commented 1 month ago

I think this super low-risk and can go to 2.5

FWIW the only change I made here was to move the draw functions to the base class, no further adjustments.