search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.25k stars 1.24k forks source link

adjust FocusWidget: GoToItem uses Space in WSearchRelatedTracksMenu #13282

Open ronso0 opened 1 month ago

ronso0 commented 1 month ago

based on #12213 requested here https://github.com/mixxxdj/mixxx/pull/12213#issuecomment-2128069547

This allows to toggle the search actions and click the Search button with [Library],GoToItem, which would previously activate the actions (trigger search and close the menu).

Needs some testing with controllers !

acolombier commented 1 month ago

I'll give it a go ASAP!

ronso0 commented 1 month ago

Admittedly this was just a quick shot, I didn't even test it :grimacing:

Turns out only the main popup is considered, not its active child WSearchRelatedTracksMenu. And when cycling through the search actions, the reported focused widget is first the WSearchRelatedTracksMenu, then the QCheckBox.

ronso0 commented 3 weeks ago

@acolombier This should work now, at least LibraryControl::getFocusedWidget() now properly detects the search menu.