search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.25k stars 1.24k forks source link

Unicode DeviceSQL strings in PDB are UTF-16-BE, not UTF-16-LE #13291

Closed 0xsuk closed 3 weeks ago

0xsuk commented 1 month ago

Bug Description

Mixxx uses kaitai struct to extract data from rekordbox pdb files. rekordbox data binary was reversed by another project called crate-digger. Mixxx uses an old copy of crate-pdb.ksy file for parsing pdb files, which needs to be updated.

https://github.com/Deep-Symmetry/crate-digger/issues/14

image As shown in the image, Japanese characters are not properly displayed.

Version

No response

OS

No response

Swiftb0y commented 1 month ago

I think the title of that pull request you mentioned is backwards, it's actually utf16-le and was just previously assumed to be utf16-be. But you're right, the ksy definitions are outdated.

Swiftb0y commented 3 weeks ago

Thanks for digging through the issue, notifying us and testing the fix. It will be part of the next mixxx release.