search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.25k stars 1.24k forks source link

Preferences: apply only in slotApply() #13302

Closed ronso0 closed 4 weeks ago

ronso0 commented 1 month ago

one more step to fix #7440

Is there a specific reason to instantly apply ReplayGain settings (Normalization)?

daschuer commented 1 month ago

Is there a specific reason to instantly apply ReplayGain settings (Normalization)?

Yes. You may play a track with either ReplayGain Applied or without and adjust the Gain values watching the VU Meters. If we Apply() with an extra button changes are applied without a gentle ramp. There is a Risk to blow your speakers because of insane gains. Maybe it is a good idea to place a note at the slider box that output is immediately affected. The the jump problem already applies to the checkbox. This should probably be covered in the note.

ronso0 commented 1 month ago

That makes sense. I would rather have a checkbox “Apply settings immediately”, but I don't feel like refactoring this it at the moment. I'll revert and only keep the groupbox / tabstop tweaks.