Move download, SHA256 check and unzip of Windows buildenv from windows_buildenv.bat to CMakelists.txt

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.

http://mixxx.org

Other

4.43k stars 1.27k forks source link

Move download, SHA256 check and unzip of Windows buildenv from windows_buildenv.bat to CMakelists.txt #13306

Open JoergAtGithub opened 4 months ago

JoergAtGithub commented 4 months ago

This move the VCPKG buildenv download, SHA256 verification and unzipping into CMakelists.txt. This removes the need for third party tools like 7zip and Powershell (see #11524 for reference).

For the developer everything should behave as before. No change in the build instructions is neccessary - just the tasks mentioned above are executed later.

Out of scope of this PR is:

macOS
Replacing windows_buildenv.bat and CMakeSettings.json by CMake Presets

JoergAtGithub commented 2 months ago

@daschuer Friendly Ping

JoergAtGithub commented 1 month ago

@daschuer Can we merge this?

JoergAtGithub commented 3 weeks ago

@daschuer Can we merge this now?