search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.25k stars 1.24k forks source link

2.5 changelog structuring #13313

Closed ronso0 closed 3 weeks ago

ronso0 commented 3 weeks ago

this is only a first step.

TODO

daschuer commented 3 weeks ago

Oh sorry, we touched the same file at the same time .. Do you want to cherry pick: https://github.com/mixxxdj/mixxx/pull/13315

I will now also prepare a 2.4 changelog update.

ronso0 commented 3 weeks ago

Thanks, I picked the changes manually, not in the mood to fix pick/merge conflicts ; )

ronso0 commented 3 weeks ago

Doe sany have an idea how to fix the issue with metainfo hook?

double-check /res/linux/org.mixxx.Mixxx.metainfo.xml, backticks ` in CHANGELOG.md are causing linebreaks

daschuer commented 3 weeks ago

Does any have an idea how to fix the issue with metainfo hook?

This is not an issue, because they are only in the xml source not in the rendered HTML. The issue is that appstream-util does not support <code> and that's why we remove the code tags.

https://github.com/mixxxdj/mixxx/blob/4d9db3e5d0e4807bdcddaebf8c87bdc3e3970d53/tools/update_metainfo.py#L87-L89

ronso0 commented 3 weeks ago

Alright, thanks for the clarification!

daschuer commented 3 weeks ago

Is this ready for merge than?

ronso0 commented 3 weeks ago

yes, Only the remaining items in the Features section should be sorted somewhere else. I'll be afk, maybe the entire day, so if anyone wants to take over or just merge and fix directly, please go ahead.

ronso0 commented 3 weeks ago

Thanks, I was about to start the finish : )