search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.25k stars 1.24k forks source link

Fix Sony SixxAxis controller not working #13319

Closed marios1861 closed 3 weeks ago

marios1861 commented 3 weeks ago

Minor fix in mapping file of sony sixxaxis controller. A wrong HIDPacket initialization was setting the length to 0, thus packets couldn't be parsed.

daschuer commented 3 weeks ago

Unfortunately the Ci is failing:

  13:9  error  'packet' is not defined  no-undef
  14:9  error  'packet' is not defined  no-undef
marios1861 commented 3 weeks ago

My thinking was to first get the original mapping back to functional with minimal changes (achieved through this PR) and create an additional mapping without the bugs of this mapping in a separate PR. If you believe these two steps should be combined into a single PR and this dysfunctional mapping should be wholly overwritten, I will keep this PR as a draft and add the revised mapping.

marios1861 commented 3 weeks ago

@Swiftb0y all done!

Swiftb0y commented 3 weeks ago

Thank you very much. Looking forward to your follow up PR.