mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.25k stars 1.24k forks source link

(fix) Pref Mixer: don't update EQs/QuickEffects while applying #13333

Closed ronso0 closed 2 weeks ago

ronso0 commented 3 weeks ago

I just noticed a bug in the Mixer preferences:

Reason was that the effectChanged callback resets the pref UI to the current engine state, i.e. wipes pending changes. Fixed with yet another bool flag.

I adopted this scheme for the similiar callback for QuickEffects and removed the extra slot (which didn't set m_quickEffectIndiciesOnUpdate anyway, i.e. would needlessly reload the QuickEffect and potentially reset the Super knob).