search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.24k stars 1.24k forks source link

Skins: add 'beats undo' button #13339

Open ronso0 opened 2 weeks ago

ronso0 commented 2 weeks ago

Besides the buttons, this also adds a new read-only control beats_undo_possible which is updated if beats change or BPM lock is toggled and allows to deactivate (cover) the Undo button. (this restores the big CurPos button in Tango & LateNight)

image image image image

ronso0 commented 2 weeks ago

That failing Coveralls summary page doesn't make much sense to me https://coveralls.io/builds/67966984

acolombier commented 2 weeks ago

That failing Coveralls summary page doesn't make much sense to me https://coveralls.io/builds/67966984

Have you tried to sync main in your branch? It might happen that some of the recent bits I've made for STEM are detected as removed, thus why it would flag some of the engine code not covered anymore

ronso0 commented 2 weeks ago

Hmm, I'm pretty sure I worked on top of 2.5

acolombier commented 2 weeks ago

My bad - I didn't see the upstream of this PR. Might still worth trying to rebase upstream/2.5 as I guess that might have confused coveralls?

ronso0 commented 1 week ago

Might still worth trying to rebase upstream/2.5 as I guess that might have confused coveralls?

Yep, that did the trick!

ronso0 commented 1 week ago

This is ready for review!