Adds Artist/track information when streaming even when that is left blank or 'static' artist details selected

[palaran]

Bug Description

Mixxx 2.4 on Windows 10.

When live broadcasting, and if you do not want to send artist/track information to the stream, Mixxx is still sending that information even if the meta data 'format' field is left blank. Similarly, if I select 'use static artist and title' it still sends the track artist/title. I checked that both leaving the static artist/static track details blank, and also putting some text in there. Ignores the static information and still sends the track artist/track name.

Version

2.4

OS

Windows 10

[ronso0]

What is sent if you enter any string into the static field, e.g. ., or a whitespace? Which encoder did you select? (shouldn't matter but..)

Note: I'm just too lazy to set up a local icecast host ; )

Here's the relevant code https://github.com/mixxxdj/mixxx/blob/af08fd1ae4156d8882eb73c7b4a7f740cd68b4eb/src/engine/sidechain/shoutconnection.cpp#L883-L901

[J-Marie123]

If you are using Live365, they require metada for copyright use. I'm only aware of live performances not having copyright requirements for broadcast

[palaran]

Encoder was Icecast 2

When I put text into the static artist and static track details it appeared to ignore that completely and instead simply send the artist/track information of the track that was playing.

[ronso0]

So the "static" checkbox is ignored entirely, regardless the artist+title fields?

I'm checking src/engine/sidechain/shoutconnection.cpp just now but (besides some irritating variable naming) I can't spot an obvious flaw in the metadata update calls. Will try to set up icecast host and add some trace output.

[palaran]

That's certainly what appeared to be happening when I did a stream with static checkbox selected and both either nothing or some text in the relevant static artist/title box. Still sent the specific artist/track data each time the track changed, and did not seem to be sending the static data at all.

[ronso0]

Yeij, still have my icecast configured. But I can't confirm, 'static' works exactly as expected.

• local icecast2 server
• broadcast profile: stream name: MixxxRonsoFx format: MP3 bitrate: 128 metadata format: (empty) static metadata: :heavy_checkmark: artist: (empty) title: (empty)_
• listen with VLC: window title says "MixxxRonsoFx - VCL" and that remains, no matter what tracks I play, how I set the crossfader etc.

Mixxx 2.4.1, Linux (Ubuntu Studio 20.04.x) libshout version: 2.4.1 Icecast version: 2.4.4

[ronso0]

Which libshout version do you use? (this is logged during Mixxx startup, see mixxx.log)

What value does the <EnableMetadata> node have in your broadcast profile xml? Should be 1 for static metadata.

Not sure how to debug this. Could add trace output all over the place..

[palaran]

Hrrrm, when I went back in and tried it again it works fine.

I do have a number of different streams set up so I do wonder whether it is possible that I accidentally edited the metatdata settings for a different one to the one that I then ultimately streamed on to test. If so I apologise for causing unnecessary worry.

Need to go take the kids to swimming but will play with this a bit when I get back, and if I can't reproduce will put down to user error. Either way will report back in a few hours.

[palaran]

So, appears I owe aplogies - have played with it a bit with various different settings and can confirm that for me it is working. Can only assume that I was editing the wrong stream details previously. Sorry for wasting your time.

[ronso0]

Never mind.