search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.24k stars 1.24k forks source link

ShoutConnection: improve code style, log metadata update info #13346

Open ronso0 opened 2 weeks ago

ronso0 commented 2 weeks ago

Just did it :tm: while looking for the cause of #13343 / #13345

Don't really care if / to which branch this is merged. Will add some more debug output in case @palaran can confirm #13345

ronso0 commented 2 days ago

Thanks @acolombier for your review! I agree with all of it (except the tr topic: since this is targeting 2.4 we must not break translations if not necessary).

Tbh I'm not particularly interested in this code, I just came across it when looking for bug potential. Almost all changes are renaming, style fixes and inverting a bool member, and I have no intentions to improve this further.

I suggest to merge this and leave the review open so we can refer to it in a feature request ("Clean up /refactor shoutconnection.cpp") so anyone looking for a starter bug can pick it up.