Optimize BPMDelegate::paintItem

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.

http://mixxx.org

Other

4.24k stars 1.24k forks source link

Optimize BPMDelegate::paintItem #13358

Closed JoergAtGithub closed 1 week ago

JoergAtGithub commented 2 weeks ago

Execute expensive setStleSheet only, if textcolor of BPM checkbox(padlock) changed. This change shows a significiant performance gain in the profiler during library scrolling - but that's unfortunately not enough to solve #11603 alone.

daschuer commented 2 weeks ago

This is also a regression fix from https://github.com/mixxxdj/mixxx/commit/3d8054c3f224c4a2e6e19b356810c1325a1aacd3 Part of the 2.5 branch. Please rebase it as well.

JoergAtGithub commented 2 weeks ago

Rebased!