search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.24k stars 1.24k forks source link

use enum class for waveform overview type #13370

Open ronso0 opened 1 week ago

ronso0 commented 1 week ago

Follow-up for #13273

Swiftb0y commented 1 week ago

@daschuer do you want to take a look? also @ronso0 do you have nerves to test out https://github.com/mixxxdj/mixxx/pull/13370/files#r1641522940 ?

ronso0 commented 5 days ago

@Swiftb0y Looks good with the latest changes?

Swiftb0y commented 5 days ago

yes, the last remaining unresolved comment is https://github.com/mixxxdj/mixxx/pull/13370#discussion_r1641522940

Swiftb0y commented 2 days ago

yes, the last remaining unresolved comment is #13370 (comment)

@ronso0 friendly ping ;)

ronso0 commented 2 days ago

Isn't that fixed by the last fixup? https://github.com/mixxxdj/mixxx/compare/91d9f6c724edf0540d8d595516f9cb8247ec1652..e8eea9fe25e505f4ddbefaa93741711d1224efda

Swiftb0y commented 2 days ago

I guess the link anchor doesn't work properly. I'm referring to this request :sweat_smile: : image

ronso0 commented 2 days ago

Oh-oh-kay, got it now :grimacing: