search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.24k stars 1.24k forks source link

Compile errors in `WaveformRendererTextured` when building for iOS (OpenGL ES 3.0) #13380

Closed fwcd closed 1 week ago

fwcd commented 1 week ago

Bug Description

Parts of the new waveform renderer unfortunately no longer build for iOS (and possibly other platforms using OpenGL ES):

Screenshot 2024-06-16 at 16 45 51

We might have to investigate which parts to cond-compile out when using GL ES (e.g. testing for QT_OPENGL_ES_2).

Version

https://github.com/fwcd/mixxx/commit/ea5e98073c15efb4c60f611fb67af457bb5be8ac (based on c368119262913411f94766a3e59735678bd72832)

OS

macOS 14.5

Swiftb0y commented 1 week ago

maybe just a transitive header dependency thats not fulfilled because the required #include has been compiled out (unnecessarily)?

fwcd commented 1 week ago

Doesn't seem so unfortunately, it looks like these are APIs unavailable in OpenGL ES (including OpenGLES/ES3/gl.h doesn't change anything, also other function calls like glBindTexture seem to work as expected).

Edit: https://docs.gl seems to confirm that functions like glBegin are missing in ES.

fwcd commented 1 week ago

A potential future refactoring is tracked by