search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.25k stars 1.24k forks source link

fix(engine-prime): build-failure #13397

Closed Swiftb0y closed 6 days ago

Swiftb0y commented 1 week ago

Explicitly instantiate default destructor in out-of-line (in .cpp) because destructing a std::unique_ptr<Waveform> needs Waveform to be complete at the point of destruction.

Swiftb0y commented 1 week ago

Interestingly, this only surfaced because of f031f51393c5ae2bb923fc331408330878285617

Swiftb0y commented 1 week ago

right, but ~EnginePrimeExportJob doesn't need to be virtual as the class is not designed to be inherited from technically, but I'll add it anyways.

daschuer commented 6 days ago

The virtual keyword is redundant.