search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.25k stars 1.24k forks source link

add maping for Intech TEK2 #13405

Closed Greg-Orca closed 6 hours ago

Greg-Orca commented 6 days ago

TEK2 config files

https://mixxx.zulipchat.com/#narrow/stream/113295-controller-mapping/topic/Intech.20TEK2

Swiftb0y commented 6 days ago

Welcome and thanks for upstreaming this mapping. Please sign the Mixxx Contributor Agreement and comment here when you have done so. It gives us permission to distribute your contribution under the GPL v2 or later license and the Apple Mac App Store. It is also helpful for us to have contact information for contributors in case we may need it in the future.

ronso0 commented 6 days ago

Thank you for this PR!

Controller mappings usually go to the stable branch (currently 2.4), unless they require new features. I've changed the base branch to 2.4, please rebase onto that and force-push. Thank you.

Greg-Orca commented 4 days ago

@Swiftb0y Hi, I signed the contract. Thank you!

Swiftb0y commented 4 days ago

Great. Thank you.

You will need to rebase this branch so it gets merged into the next release. To do that, issue the following commands:

git switch -c intech-tek2 # put your work on a new branch
git switch main # go back to main branch
git reset --hard 6b62210eed71869fb2dd39c12261328912caf528 # ensure main branch is clean
git switch intech-tek2 # go back to your work
git rebase --onto=2.4 main # this is the step that actually does the rebase on 2.4
git push # publish

Then you'll probably need to create a new PR because the PR should now be originating from your intech-tek2 branch.

Please also understand that in order for us to be able to merge this, your contribution need to follow our style guide. Most of the required changes can be made automatically by use of pre-commit. Please set up pre-commit and make sure to manually apply the required changes using pre-commit run --from-ref 2.4 --to-ref HEAD. Thank you very much.