search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.44k stars 1.27k forks source link

Mixxx incorrectly detects silence at the end of some (few) tracks #13449

Closed Gilles-Poulleau closed 1 month ago

Gilles-Poulleau commented 3 months ago

Bug Description

I have experienced Mixxx incorrectly detecting silence at the end of some (few) tracks. It's different from #10791 replacing a track with a better version leads to the risk of the song being cut off abruptly during broadcast. For these files, resetting the parameters doesn't change anything, the new analysis gives the same result which leads to the same behaviour in AUTO-DJ. Except if your are in full track mode, the end of the track is abruptly cut, leading to dancers bad experience and it's much worse for the DJ.

By the way, if I detect the problem, removing the mark before the incorrect end, makes the mark disappear from the waveform but the song will still be cut too early.... ? The only way around is too quickly select "full track" mode. mixx incorrectly detecting end of track 2 mixx incorrectly detecting end of track - Humillación Que Nadie Sepa Mi Sufrir too early cut.zip

Version

2.4.1

OS

Windows 11

Swiftb0y commented 3 months ago

Can confirm on Fedora 40 as well. filetype/decoder doesn't matter afaict.

ronso0 commented 2 months ago

By the way, if I detect the problem, removing the mark before the incorrect end, makes the mark disappear from the waveform but the song will still be cut too early.... ?

Initially, the outro_end marker is positioned at what the analyzer considers the last sound (level falls below -60dB). However, manally moving or removing the outro_end will unfortunately not re/move the 'last sound' cue.

ronso0 commented 2 months ago

@Gilles-Poulleau @Swiftb0y Could you test affected with some earlier Mixxx version (2.3.x)?

Gilles-Poulleau commented 1 month ago

Sorry for the delay. I have been able to test it with mixxx version 2.3.3. And it works fine, the end of both songs is correctly detected in this version.

daschuer commented 1 month ago

I see. It is a regression form https://github.com/mixxxdj/mixxx/commit/d993c034a553e16063abf6f530fc1acad00e141e when introducing the std::reverse_iterator I will take a look.

Swiftb0y commented 1 month ago

for the record, 9f99531524358de303162703965b94d8bf9c8467 was probably the culprit. fixed by #13545