mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.4k stars 1.26k forks source link

AutoDJ seems to spontaneously turn off #13544

Open eszekeres opened 1 month ago

eszekeres commented 1 month ago

Bug Description

I know this is pretty vague, but ever since updating to Mixxx 2.4.1 I have been having issue with AutoDJ just turning off spontaneously. I use AutoDJ to run some private icecast streams to allow me to listen to continuous mixes from my collection on various devices/locations. Lately I find that it just seems to turn off randomly for no apparent reason. Pushing the AutoDJ button turns it back on without any issue. Mostly posting to see if others intances of this occurring

Version

2.4.1

OS

Window 10 Pro, Intel i9-13900K, 8G RAM

daschuer commented 1 month ago

The last significant changes in Auto DJ have been made for 2.4.0 fixing similar bugs, and I have no idea what could be the cause in 2.4.1 for this regression.

But let's investigate. Are you sure the Auto DJ is turned off, after it stops playing? Is the Auto DJ enable button really in off state, or do you need to turn it off and on again to continue playing?

What is the situation of the decks and crossfader when the issue occurs? A screenshot of Mixxx in the faulty stopped state might give additional info.

Which transition mode do you use?

By luck there is still a mixxx.log file from the faulty run. Mixxx keeps some old copies with a number post-fix. https://github.com/mixxxdj/mixxx/wiki/Finding-the-mixxx.log-file Can you share it?

Does the issue happen again if you play the same 5 tracks before the stop in AutoDJ? All played tracks are stored in the history.

eszekeres commented 1 month ago

Ok, so typically I have the playlist set to autoselect

Found this in the log, for some reason the playlist stopped loading and you can watch it run out, and then autodj was switched off. From the messages looks like it lost the ability to read from my “M” drive that has all my mp3….but it must be transitory, as the drive seems fine and passes all disk checks, and I don’t seem to hav problems reading a writing mp3s. There are times where it has run for weeks without an issue, so it is more random. Probably this ticket can be closed. Cheers

Debug [Main] BaseTrackCache(0x1c5cadc61e0) updateIndexWithQuery took 0 ms
Debug [Main] Committing transaction successfully on "MIXXX-1"
Debug [Main] PlaylistTableModel(0x1c5d1dfb440) select() returned 3 results in 0 ms
Debug [Main] Successfully deserialized Beats ("BeatGrid-2.0")
Debug [Main] Successfully deserialized KeyMap
Info [Main] Unable to detect MIME type from file "M:/Glowworm/Harvest/05 Glowworm - Manta.mp3"
Info [Main] Unable to detect MIME type from file "M:/Glowworm/Harvest/05 Glowworm - Manta.mp3"
Warning [Main] TagLib - Cannot read audio properties from inaccessible/unreadable/invalid file: "M:/Glowworm/Harvest/05 Glowworm - Manta.mp3"
Info [Main] MetadataSourceTagLib - No track metadata or cover art found in file "M:/Glowworm/Harvest/05 Glowworm - Manta.mp3" with type 3
Debug [Main] BaseTrackCache(0x1c5cadc61e0) updateIndexWithQuery took 0 ms
Debug [Main] Committing transaction successfully on "MIXXX-1"
Debug [Main] PlaylistTableModel(0x1c5d1dfb440) select() returned 2 results in 0 ms
Debug [Main] Successfully deserialized Beats ("BeatGrid-2.0")
Debug [Main] Successfully deserialized KeyMap
Info [Main] Unable to detect MIME type from file "M:/Entheogenic/Flight Of The Urubus/07 Entheogenic - Vervain.mp3"
Info [Main] Unable to detect MIME type from file "M:/Entheogenic/Flight Of The Urubus/07 Entheogenic - Vervain.mp3"
Warning [Main] TagLib - Cannot read audio properties from inaccessible/unreadable/invalid file: "M:/Entheogenic/Flight Of The Urubus/07 Entheogenic - Vervain.mp3"
Info [Main] MetadataSourceTagLib - No track metadata or cover art found in file "M:/Entheogenic/Flight Of The Urubus/07 Entheogenic - Vervain.mp3" with type 3
Debug [Main] BaseTrackCache(0x1c5cadc61e0) updateIndexWithQuery took 0 ms
Debug [Main] Committing transaction successfully on "MIXXX-1"
Debug [Main] PlaylistTableModel(0x1c5d1dfb440) select() returned 1 results in 0 ms
Debug [Main] Successfully deserialized Beats ("BeatGrid-2.0")
Debug [Main] Successfully deserialized KeyMap
Info [Main] Unable to detect MIME type from file "M:/Various Artists/Ritualrequiem/10 Ugasanie - Ritual.mp3"
Info [Main] Unable to detect MIME type from file "M:/Various Artists/Ritualrequiem/10 Ugasanie - Ritual.mp3"
Warning [Main] TagLib - Cannot read audio properties from inaccessible/unreadable/invalid file: "M:/Various Artists/Ritualrequiem/10 Ugasanie - Ritual.mp3"
Info [Main] MetadataSourceTagLib - No track metadata or cover art found in file "M:/Various Artists/Ritualrequiem/10 Ugasanie - Ritual.mp3" with type 3
Debug [Main] BaseTrackCache(0x1c5cadc61e0) updateIndexWithQuery took 0 ms
Debug [Main] Committing transaction successfully on "MIXXX-1"
Debug [Main] PlaylistTableModel(0x1c5d1dfb440) select() returned 0 results in 0 ms
Debug [Main] Auto DJ disabled
Debug [Main] stray BaseTrackPlayerImpl::slotTrackLoaded()
Debug [Main] 5936 5936

(edit: cleaned up the responds for readability)

daschuer commented 1 month ago

OK I see it looks like that autoselect does not work in case Auto DJ skips unreadable tracks. It is also interesting that reading the track does not fail earlier with a better error message. I will take a look.

eszekeres commented 1 month ago

It did it again, whole log is attached. One thing I will comment is that you logs do not have time stamps, so it is difficult to correlate when in time lines refer to…

daschuer commented 1 month ago

I have created the PR #13551 to fix this issue. You can download test build after logging in to GitHub here: https://github.com/mixxxdj/mixxx/actions/runs/10314870318?pr=13551

The email attachment is not accessible. Can you attach it via the web interface?

eszekeres commented 1 month ago

Thanks for the super-fast responsiveness. I have downloaded the test build and will let you know…..

cheers

daschuer commented 1 month ago

Cool, can you also attach the mixxx.log if files are considered as missing? I like to check if the log now looks reasonable.

What is your M: drive? What must have been happen with it to reproduce the issue? Maybe we can add also a special case handling for it. Adjusting timeouts or retries or such.