search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.4k stars 1.26k forks source link

Information is lost if Mixxx is not properly closed #13616

Open osoitz opened 2 weeks ago

osoitz commented 2 weeks ago

Bug Description

Sometimes, information is not saved, like:

This happens when I don't close Mixxx with the top right button, for example, when I logout or reboot the computer while Mixxx is open

Version

2.4.1 Flatpak

OS

Fedora KDE 40

ronso0 commented 2 weeks ago

Yes, if you kill an application, this can cause loss of information. I don't what your Fedora does, how long it waits for apps to shutdown gracefully.

osoitz commented 2 weeks ago

Fedora is not killing Mixxx straight away. When I reboot, the dialog "A deck is playing. Exit Mixxx? Yes/No" shows up, and it waits for my answer. If I say "No" the computer is not reboot.

Edit: This seems related: https://fedoraproject.org/wiki/Changes/Shorter_Shutdown_Timer

osoitz commented 2 weeks ago

Updated description, information loss does not depend on rebooting

ronso0 commented 2 weeks ago

information might not be updated also when closing Mixxx with the top right button

That can happen when Mixxx doesn't close properly, ie. crashes during shutdown for some reason. When you notice that info you added/changed in the previous session hasn't been stored correctly, you may take a look at the log of that previous session. maybe that contains a clue. Logs are rotated, so the previous log is mixxx.log.1.

daschuer commented 2 weeks ago

You may also run Mixxx with gdb: https://github.com/mixxxdj/mixxx/wiki/Creating-Backtraces#linux--mac-os-x-with-xcode-4x

osoitz commented 2 weeks ago

Update

1) I could not reproduce Mixxx losing information when it's closed with the top right button, so maybe I got confused, removed that.

2) The difference I see in the logs is that when Mixxx is closed with the button, it prints several lines to the log after the button is clicked, mentioning that it disconnects from the database, but when it's closed by the system (for example on logout) it prints nothing

3) It seems a Fedora thing. It also happens in Fedora Workstation 40 (Gnome), but it does not happen in KDE Neon, or EndeavourOS

Swiftb0y commented 2 weeks ago

That implies that mixxx is indeed just killed on the spot, giving it no chance to save any pending changes to the database. I'm not sure how much we can realistically do about this.