search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.4k stars 1.26k forks source link

Issues with Mixtrack 3 Mapping #13639

Open amakea opened 1 week ago

amakea commented 1 week ago

Bug Description

Hi. Since 2.4.0, Numark Mixtrack 3 mapping is acting funny. Shift+button is not working. A few people are reporting this here.

for some reason a lot of the shift, pad mode, and tap functions that are on the manual straight up don’t work.

It's giving a number of warnings...

controller.mixtrack3midi1:warning [Controller] "Script tried to connect to ([Channel2], volume) using `connectControl` which is deprecated. Use `makeConnection` instead!"
 controller.mixtrack3midi1:warning [Controller] "Script tried to connect to ([Channel2], pfl) using `connectControl` which is deprecated. Use `makeConnection` instead!"
 controller.mixtrack3midi1:warning [Controller] "Script tried to connect to ([Channel2], duration) using `connectControl` which is deprecated. Use `makeConnection` instead!"
 controller.mixtrack3midi1:warning [Controller] "Script tried to connect to ([Channel2], play_indicator) using `connectControl` which is deprecated. Use `makeConnection` instead!"
 controller.mixtrack3midi1:warning [Controller] "Script tried to connect to ([Channel2], cue_indicator) using `connectControl` which is deprecated. Use `makeConnection` instead!"
 controller.mixtrack3midi1:warning [Controller] "Script tried to connect to ([Channel2], loop_start_position) using `connectControl` which is deprecated. Use `makeConnection` instead!"
 controller.mixtrack3midi1:warning [Controller] "Script tried to connect to ([Channel2], loop_end_position) using `connectControl` which is deprecated. Use `makeConnection` instead!"
 controller.mixtrack3midi1:warning [Controller] "Script tried to connect to ([Channel2], loop_enabled) using `connectControl` which is deprecated. Use `makeConnection` instead!"
 controller.mixtrack3midi1:warning [Controller] "Script tried to connect to ([Channel2], sync_enabled) using `connectControl` which is deprecated. Use `makeConnection` instead!"
 controller.mixtrack3midi1:warning [Controller] "Script tried to connect to ([Channel2], beatloop_2_enabled) using `connectControl` which is deprecated. Use `makeConnection` instead!"
 controller.mixtrack3midi1:warning [Controller] "Script tried to connect to ([Channel2], beatloop_4_enabled) using `connectControl` which is deprecated. Use `makeConnection` instead!"
 controller.mixtrack3midi1:warning [Controller] "Script tried to connect to ([Channel2], beatloop_8_enabled) using `connectControl` which is deprecated. Use `makeConnection` instead!"
 controller.mixtrack3midi1:warning [Controller] "Script tried to connect to ([Channel2], beatloop_16_enabled) using `connectControl` which is deprecated. Use `makeConnection` instead!"
 controller.mixtrack3midi1:warning [Controller] "Script tried to connect to ([Channel2], beatloop_0.125_enabled) using `connectControl` which is deprecated. Use `makeConnection` instead!"
 controller.mixtrack3midi1:warning [Controller] "Script tried to connect to ([Channel2], beatloop_0.25_enabled) using `connectControl` which is deprecated. Use `makeConnection` instead!"
 controller.mixtrack3midi1:warning [Controller] "Script tried to connect to ([Channel2], beatloop_0.5_enabled) using `connectControl` which is deprecated. Use `makeConnection` instead!"
 controller.mixtrack3midi1:warning [Controller] "Script tried to connect to ([Channel2], beatloop_1_enabled) using `connectControl` which is deprecated. Use `makeConnection` instead!"
warning [Controller] "Could not convert argument 1 at"
warning [Controller]     "sendShortMsg@file:///home/user/.mixxx/controllers/Numark-Mixtrack-3-scripts.js:213"
warning [Controller]     "@file:///home/user/.mixxx/controllers/Numark-Mixtrack-3-scripts.js:273"
warning [Controller]     "@file:///home/user/.mixxx/controllers/Numark-Mixtrack-3-scripts.js:1312"
warning [Controller] "Passing incompatible arguments to C++ functions from JavaScript is dangerous and deprecated."
warning [Controller] "This will throw a JavaScript TypeError in future releases of Qt!"
warning [Controller] "Could not convert argument 1 at"
warning [Controller]     "sendShortMsg@file:///home/user/.mixxx/controllers/Numark-Mixtrack-3-scripts.js:213"
warning [Controller]     "@file:///home/user/.mixxx/controllers/Numark-Mixtrack-3-scripts.js:273"
warning [Controller]     "@file:///home/user/.mixxx/controllers/Numark-Mixtrack-3-scripts.js:1312"
warning [Controller] "Passing incompatible arguments to C++ functions from JavaScript is dangerous and deprecated."
warning [Controller] "This will throw a JavaScript TypeError in future releases of Qt!"
warning [Controller] "Could not convert argument 2 at"
warning [Controller]     "sendShortMsg@file:///home/user/.mixxx/controllers/Numark-Mixtrack-3-scripts.js:213"
warning [Controller]     "@file:///home/user/.mixxx/controllers/Numark-Mixtrack-3-scripts.js:382"
warning [Controller]     "@file:///home/user/.mixxx/controllers/Numark-Mixtrack-3-scripts.js:370"
warning [Controller] "Passing incompatible arguments to C++ functions from JavaScript is dangerous and deprecated."
warning [Controller] "This will throw a JavaScript TypeError in future releases of Qt!"
warning [Controller] "Could not convert argument 2 at"
warning [Controller]     "sendShortMsg@file:///home/user/.mixxx/controllers/Numark-Mixtrack-3-scripts.js:213"
warning [Controller]     "@file:///home/user/.mixxx/controllers/Numark-Mixtrack-3-scripts.js:382"
warning [Controller]     "@file:///home/user/.mixxx/controllers/Numark-Mixtrack-3-scripts.js:370"

I change the things to "makeConnection" and then more problems happen, perhaps I need to do more.

warning [Controller] ControlObject accessed via deprecated key "[Channel2]" "hotcue_1_enabled" - use "[Channel2]" "hotcue_1_status" instead
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel2], hotcue_1_enabled) to an invalid callback. Make sure that your code contains no syntax errors."
warning [Controller] ControlObject accessed via deprecated key "[Channel2]" "hotcue_2_enabled" - use "[Channel2]" "hotcue_2_status" instead
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel2], hotcue_2_enabled) to an invalid callback. Make sure that your code contains no syntax errors."
warning [Controller] ControlObject accessed via deprecated key "[Channel2]" "hotcue_3_enabled" - use "[Channel2]" "hotcue_3_status" instead
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel2], hotcue_3_enabled) to an invalid callback. Make sure that your code contains no syntax errors."
warning [Controller] ControlObject accessed via deprecated key "[Channel2]" "hotcue_4_enabled" - use "[Channel2]" "hotcue_4_status" instead
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel2], hotcue_4_enabled) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel2], track_samples) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel2], vu_meter) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel2], playposition) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel2], volume) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel2], pfl) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel2], duration) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel2], play_indicator) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel2], cue_indicator) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel2], loop_start_position) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel2], loop_end_position) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel2], loop_enabled) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel2], sync_enabled) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel2], beatloop_2_enabled) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel2], beatloop_4_enabled) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel2], beatloop_8_enabled) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel2], beatloop_16_enabled) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel2], beatloop_0.125_enabled) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel2], beatloop_0.25_enabled) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel2], beatloop_0.5_enabled) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel2], beatloop_1_enabled) to an invalid callback. Make sure that your code contains no syntax errors."

Thank you for your time.

Version

2.4.1-4

OS

Arch Linux

Swiftb0y commented 1 week ago

Hey there, thanks for reporting your issue. Lets get to the bottom of this. Can you reproduce the problem in your makeConnection variant when you disable the mapping in the preferences and then manually enable it again? I assume these logs are from the messages occurring when starting mixxx?

amakea commented 1 week ago

Yes, I can reproduce it. Here is the full log using the makeConnection version. The program starts up with the mapping disabled, and then I enable it in the preferences. Along with the errors, all the LED's will then light up the controller.

$ mixxx
Using preferences ScaleFactor 1
Loading resources from  "/usr/share/mixxx/"
Configuration file is at the current version "2.4.1"
BroadcastSettings - Found 1 profile(s)
ALSA lib confmisc.c:1377:(snd_func_refer) Unable to find definition 'cards.0.pcm.front.0:CARD=0'
ALSA lib conf.c:5204:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:5727:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2722:(snd_pcm_open_noupdate) Unknown PCM front
ALSA lib pcm.c:2722:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.rear
ALSA lib pcm.c:2722:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.center_lfe
ALSA lib pcm.c:2722:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.side
ALSA lib confmisc.c:1377:(snd_func_refer) Unable to find definition 'cards.0.pcm.surround51.0:CARD=0'
ALSA lib conf.c:5204:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:5727:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2722:(snd_pcm_open_noupdate) Unknown PCM surround21
ALSA lib confmisc.c:1377:(snd_func_refer) Unable to find definition 'cards.0.pcm.surround51.0:CARD=0'
ALSA lib conf.c:5204:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:5727:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2722:(snd_pcm_open_noupdate) Unknown PCM surround21
ALSA lib confmisc.c:1377:(snd_func_refer) Unable to find definition 'cards.0.pcm.surround40.0:CARD=0'
ALSA lib conf.c:5204:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:5727:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2722:(snd_pcm_open_noupdate) Unknown PCM surround40
ALSA lib confmisc.c:1377:(snd_func_refer) Unable to find definition 'cards.0.pcm.surround51.0:CARD=0'
ALSA lib conf.c:5204:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:5727:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2722:(snd_pcm_open_noupdate) Unknown PCM surround41
ALSA lib confmisc.c:1377:(snd_func_refer) Unable to find definition 'cards.0.pcm.surround51.0:CARD=0'
ALSA lib conf.c:5204:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:5727:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2722:(snd_pcm_open_noupdate) Unknown PCM surround50
ALSA lib confmisc.c:1377:(snd_func_refer) Unable to find definition 'cards.0.pcm.surround51.0:CARD=0'
ALSA lib conf.c:5204:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:5727:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2722:(snd_pcm_open_noupdate) Unknown PCM surround51
ALSA lib confmisc.c:1377:(snd_func_refer) Unable to find definition 'cards.0.pcm.surround71.0:CARD=0'
ALSA lib conf.c:5204:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:5727:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2722:(snd_pcm_open_noupdate) Unknown PCM surround71
ALSA lib confmisc.c:1377:(snd_func_refer) Unable to find definition 'cards.0.pcm.iec958.0:CARD=0,AES0=4,AES1=130,AES2=0,AES3=2'
ALSA lib conf.c:5204:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:5727:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2722:(snd_pcm_open_noupdate) Unknown PCM iec958
ALSA lib confmisc.c:1377:(snd_func_refer) Unable to find definition 'cards.0.pcm.iec958.0:CARD=0,AES0=4,AES1=130,AES2=0,AES3=2'
ALSA lib conf.c:5204:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:5727:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2722:(snd_pcm_open_noupdate) Unknown PCM spdif
ALSA lib confmisc.c:1377:(snd_func_refer) Unable to find definition 'cards.0.pcm.iec958.0:CARD=0,AES0=4,AES1=130,AES2=0,AES3=2'
ALSA lib conf.c:5204:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:5727:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2722:(snd_pcm_open_noupdate) Unknown PCM spdif
ALSA lib confmisc.c:1377:(snd_func_refer) Unable to find definition 'cards.0.pcm.hdmi.0:CARD=0,AES0=4,AES1=130,AES2=0,AES3=2'
ALSA lib conf.c:5204:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:5727:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2722:(snd_pcm_open_noupdate) Unknown PCM hdmi
ALSA lib confmisc.c:1377:(snd_func_refer) Unable to find definition 'cards.0.pcm.hdmi.0:CARD=0,AES0=4,AES1=130,AES2=0,AES3=2'
ALSA lib conf.c:5204:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:5727:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2722:(snd_pcm_open_noupdate) Unknown PCM hdmi
ALSA lib confmisc.c:1377:(snd_func_refer) Unable to find definition 'cards.0.pcm.modem.0:CARD=0'
ALSA lib conf.c:5204:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:5727:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2722:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.phoneline:CARD=0,DEV=0
ALSA lib confmisc.c:1377:(snd_func_refer) Unable to find definition 'cards.0.pcm.modem.0:CARD=0'
ALSA lib conf.c:5204:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:5727:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2722:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.phoneline:CARD=0,DEV=0
ALSA lib confmisc.c:1377:(snd_func_refer) Unable to find definition 'cards.0.pcm.modem.0:CARD=0'
ALSA lib conf.c:5204:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:5727:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2722:(snd_pcm_open_noupdate) Unknown PCM phoneline
ALSA lib confmisc.c:1377:(snd_func_refer) Unable to find definition 'cards.0.pcm.modem.0:CARD=0'
ALSA lib conf.c:5204:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:5727:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2722:(snd_pcm_open_noupdate) Unknown PCM phoneline
 kf.windowsystem:warning [Main] Could not find any platform plugin
 qt.qpa.wayland:warning [Main] Wayland does not support QWindow::requestActivate()
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Sampler1], play) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Sampler2], play) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Sampler3], play) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Sampler4], play) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Sampler5], play) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Sampler6], play) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Sampler7], play) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Sampler8], play) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([EffectRack1_EffectUnit1_Effect1], enabled) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([EffectRack1_EffectUnit1_Effect2], enabled) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([EffectRack1_EffectUnit1_Effect3], enabled) to an invalid callback. Make sure that your code contains no syntax errors."
warning [Controller] ControlObject accessed via deprecated key "[Channel1]" "hotcue_1_enabled" - use "[Channel1]" "hotcue_1_status" instead
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel1], hotcue_1_enabled) to an invalid callback. Make sure that your code contains no syntax errors."
warning [Controller] ControlObject accessed via deprecated key "[Channel1]" "hotcue_2_enabled" - use "[Channel1]" "hotcue_2_status" instead
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel1], hotcue_2_enabled) to an invalid callback. Make sure that your code contains no syntax errors."
warning [Controller] ControlObject accessed via deprecated key "[Channel1]" "hotcue_3_enabled" - use "[Channel1]" "hotcue_3_status" instead
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel1], hotcue_3_enabled) to an invalid callback. Make sure that your code contains no syntax errors."
warning [Controller] ControlObject accessed via deprecated key "[Channel1]" "hotcue_4_enabled" - use "[Channel1]" "hotcue_4_status" instead
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel1], hotcue_4_enabled) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel1], track_samples) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel1], vu_meter) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel1], playposition) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel1], volume) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel1], pfl) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel1], duration) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel1], play_indicator) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel1], cue_indicator) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel1], loop_start_position) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel1], loop_end_position) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel1], loop_enabled) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel1], sync_enabled) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel1], beatloop_2_enabled) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel1], beatloop_4_enabled) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel1], beatloop_8_enabled) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel1], beatloop_16_enabled) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel1], beatloop_0.125_enabled) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel1], beatloop_0.25_enabled) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel1], beatloop_0.5_enabled) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel1], beatloop_1_enabled) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([EffectRack1_EffectUnit2_Effect1], enabled) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([EffectRack1_EffectUnit2_Effect2], enabled) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([EffectRack1_EffectUnit2_Effect3], enabled) to an invalid callback. Make sure that your code contains no syntax errors."
warning [Controller] ControlObject accessed via deprecated key "[Channel2]" "hotcue_1_enabled" - use "[Channel2]" "hotcue_1_status" instead
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel2], hotcue_1_enabled) to an invalid callback. Make sure that your code contains no syntax errors."
warning [Controller] ControlObject accessed via deprecated key "[Channel2]" "hotcue_2_enabled" - use "[Channel2]" "hotcue_2_status" instead
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel2], hotcue_2_enabled) to an invalid callback. Make sure that your code contains no syntax errors."
warning [Controller] ControlObject accessed via deprecated key "[Channel2]" "hotcue_3_enabled" - use "[Channel2]" "hotcue_3_status" instead
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel2], hotcue_3_enabled) to an invalid callback. Make sure that your code contains no syntax errors."
warning [Controller] ControlObject accessed via deprecated key "[Channel2]" "hotcue_4_enabled" - use "[Channel2]" "hotcue_4_status" instead
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel2], hotcue_4_enabled) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel2], track_samples) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel2], vu_meter) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel2], playposition) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel2], volume) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel2], pfl) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel2], duration) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel2], play_indicator) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel2], cue_indicator) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel2], loop_start_position) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel2], loop_end_position) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel2], loop_enabled) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel2], sync_enabled) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel2], beatloop_2_enabled) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel2], beatloop_4_enabled) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel2], beatloop_8_enabled) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel2], beatloop_16_enabled) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel2], beatloop_0.125_enabled) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel2], beatloop_0.25_enabled) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel2], beatloop_0.5_enabled) to an invalid callback. Make sure that your code contains no syntax errors."
 controller.mixtrack3midi1:warning [Controller] "Tried to connect ([Channel2], beatloop_1_enabled) to an invalid callback. Make sure that your code contains no syntax errors."
warning [LibraryScanner 1] QSqlDatabasePrivate::removeDatabase: connection 'MIXXX-2' is still in use, all queries will cease to work.
Swiftb0y commented 6 days ago

Ah, right. So the makeConnection version doesn't accept a string as a callback. pass a function directly. That shouldn't be very complicated fortunately. You'll just need to remove the " quotation marks so you pass the function directly instead of its name.

Moreover, there is a type in the script at line 755. it should be this.LEDs.cue = new LED(0x90 + j, leds.cue); (leds.cue being lowercase). That should likely fix the original issue. Can you implement both and get back to me if any other issues occur? Thanks.

amakea commented 6 days ago

Cool. I can do this. I just don't know which quotations to remove, can you please explain more? Thank you.

Swiftb0y commented 6 days ago

Having a second look, the mapping is not really setup to easily transition to makeConnection. Ignore that comment. Just focus on the issue in Line 755.

amakea commented 6 days ago

I have changed the line to this.LEDs.cue = new LED(0x90 + j, leds.cue); but that seems to make no difference.

Swiftb0y commented 6 days ago

thats weird. can you post the new log?

Swiftb0y commented 6 days ago

and add console.warn(control,midino,value); in Line 213 above the midi.sendShortMsg(control, midino, value); So I can see what the wrong values actually are.

amakea commented 6 days ago

https://termbin.com/z3sd

Swiftb0y commented 6 days ago

That log is still from the change to makeConnection. You'll need to change it back to connectControl for now.

amakea commented 6 days ago

oops. here's with just line 755 edited and warnings enabled. https://termbin.com/k51l

Swiftb0y commented 6 days ago

apply this patch and see if it makes a difference please.

diff --git a/res/controllers/Numark-Mixtrack-3-scripts.js b/res/controllers/Numark-Mixtrack-3-scripts.js
index ec7b548e96..fbeddba7b6 100644
--- a/res/controllers/Numark-Mixtrack-3-scripts.js
+++ b/res/controllers/Numark-Mixtrack-3-scripts.js
@@ -288,7 +288,7 @@ LED.prototype.onOff = function(value) {
 //           if not set, it considers it as a switch off (default=false)
 // valueoff : like "value". That permits for instance with two colors (once red(on), once blue(off), once red(on), etc...)

-LED.prototype.flashOn = function(num_ms_on, value, num_ms_off, flashCount, relight, valueoff) {
+LED.prototype.flashOn = function(num_ms_on, value, num_ms_off, flashCount) {
     // stop pending timers
     this.flashOff();

@@ -298,8 +298,6 @@ LED.prototype.flashOn = function(num_ms_on, value, num_ms_off, flashCount, relig
     this.valueon = value;
     this.num_ms_off = num_ms_off;
     this.flashCount = flashCount;
-    this.relight = relight;
-    this.valueoff = valueoff;

     // 1st flash
     // This is because the permanent timer below takes
@@ -320,7 +318,7 @@ LED.prototype.flashOn = function(num_ms_on, value, num_ms_off, flashCount, relig
         // so we don't need this part  if flashcount=1
         // temporary timer. The end of this timer stops the permanent flashing

-        this.flashTimer2 = engine.beginTimer(flashCount * (num_ms_on + num_ms_off) - num_ms_off, ()=>this.stopflash(relight), true);
+        this.flashTimer2 = engine.beginTimer(flashCount * (num_ms_on + num_ms_off) - num_ms_off, ()=>this.stopflash(this.relight), true);
     }
 };
amakea commented 6 days ago

Looks like that reduced the number of warnings, and the LED's no longer all light up, but now the controller doesn't work at all. Here's the log... https://termbin.com/a7jx

Swiftb0y commented 5 days ago

The log contains no obvious errors. I'm afraid that's all I can do with my remote troubleshooting.

amakea commented 3 days ago

I likely made some kind of misstep last time I tried your patch @Swiftb0y I redid it and the controller is responding again. Here is the updated log... https://termbin.com/j04e9

Swiftb0y commented 2 days ago

thanks. that contains something I can work with again. can you add the console.warn(value, group, control); above line 1312 so I can see the values?

amakea commented 2 days ago

Script looks like this, hope it's correct

NumarkMixtrack3.OnCuePointChange = function(value, group, control) {
    var deck = NumarkMixtrack3.deckFromGroup(group);
    deck.LEDs.cue.onOff((value) ? ON : OFF);
    console.warn(value, group, control);
};

log > https://termbin.com/cjhh

Swiftb0y commented 1 day ago

whoops, I'm sorry. I also need the console.warn in the sendShortMsg I asked you to add previously.

amakea commented 1 day ago

Got it, here you go... https://termbin.com/5okp

amakea commented 22 hours ago

Forgot the "leds.cue" edit @ line 755. Here's another log which includes it https://termbin.com/50oh

Swiftb0y commented 18 hours ago

Thanks. That missing edit was the source of the error. the log contains no errors now, so we're back at the start. What exactly is broken right now?

amakea commented 7 hours ago

Referencing the manual The following is not working for me...

  1. High EQ Knobs Adjust High frequencies of the deck SHIFT + HIGH: Adjust parameter 1 of the currently focused effect on this deck.

  2. Mid EQ Knobs Adjust Mid frequencies of the deck SHIFT + MID: Adjust parameter 2 of the currently focused effect on this deck.

  3. Low EQ Knobs Adjust Low frequencies of the deck SHIFT + LOW: Adjust parameter 3 of the currently focused effect on this deck.

  4. Filter Adjusts the amount of the filter effect. Turning the knob left controls the low pass filter; turning it right controls the high pass filter. SHIFT + FILTER: Adjust parameter 4 of the currently focused effect on this deck. If effect is unfocused then; SHIFT + FILTER Adjust the gain of the deck.

EQ's & filter on their own are working fine, trying to shift+eq/filter does not. Also, I'm not experiencing the pad and sync issues that people were reporting in the forum.

Swiftb0y commented 6 hours ago

according to the code, for those to work a filter needs to be focused. In latenight for example the effect unit should get a blue border.

amakea commented 6 hours ago

you are correct, my mistake. thanks for pointing that out. happy to close this, unless anything else needs to be addressed.