search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.41k stars 1.26k forks source link

~WORKAROUND!~Mixxx Not pushing Metadata to Shoutcast 1.x+2.x server (windows 10) #13681

Open unknownpedestrian opened 8 hours ago

unknownpedestrian commented 8 hours ago

Bug Description

When streaming to the latest version of shoutcast (selfhost)

when using mixxx as a source the title information is not being sent to the server, it updates the title as follows: Push to YP: " " for the song name every time the song changes

I've tried toggling UTF-8 and OGG dynamic updating and no dice at all

it seems all my DJs that use mixxx are having this issue where the title field in the shoutcast server is just left blank! and when I go to try and display the metadata manually it just returns a blank page! HELP!

UPDATE: I found out this issue is related to special characters being in the password!! (Ex. $#%@_-+) once i removed the special characters from the password titles started pushing through like normal!

still a bug with mixxx that is a nice work around for now!~

Version

2.4.1, 2.5.0

OS

Windows 10, windows 11

acolombier commented 4 hours ago

@daschuer I'm wondering if this is something that the libshoutcast update could fix.

daschuer commented 3 hours ago

I am not aware that something has changed, but it is worth a try.

daschuer commented 3 hours ago

I have pushed a new build. It will appear here: https://github.com/mixxxdj/mixxx/actions/runs/10980988560?pr=4723 You need to login to GitHub to see the windows installer link at the bottom of the page. Please check.

daschuer commented 2 hours ago

It is probably here: https://github.com/mixxxdj/mixxx/blob/067792b1e7e5cb524a91df6b2e83533f362c5bf1/lib/libshout-idjc/src/proto_icy.c#L43

In this place, user and password is base64 encoded: https://github.com/mixxxdj/mixxx/blob/067792b1e7e5cb524a91df6b2e83533f362c5bf1/lib/libshout-idjc/src/proto_http.c#L51

This could be a reason why steaming work, but not metadata.

@unknownpedestrian are you able to use Wireshark to compare a working implementation with the special Characters with the Mixxx implementation? I think it should be possible to escape the password appropriate.

There is anyway an issue when sending a plain text password. Is both solved with this branch:
https://github.com/mixxxdj/mixxx/pull/13285 ?