When loading a track to an autosync'ed deck, the BPM factor is defaulted to 1

[acolombier]

Bug Description

Usually, Mixxx detect the best factor (1/2, 1 or 2) to apply when sync-ing a decks together. This way, when you can sync a 100 BPM track with a 200 one without changing the rate. This behaviour however doesn't work when the deck is already sync'ed to a leader, and a track get's loaded

Current behaviour

• Load a 174 BPM track on deck A
• Make deck A sync leader
• Make deck B auto-sync'ed
• Load a 87 BPM track on deck B -> Deck B's BPM is 174 BPM. rate is 200%

Expected behaviour

• Load a 174 BPM track on deck A
• Make deck A sync leader
• Make deck B auto-sync'ed
• Load a 87 BPM track on deck B -> Deck B's BPM is 87 BPM. rate is 100%

Note that it exist a unit test case that reproduce this exact issue

Version

2.6-alpha

OS

Pop OS 22.04 (with Wayland)

[acolombier]

The root cause appears to be a race condition between the main thread, that recalculate the sync factor upon track load, and uses the BPM information which aren't yet updated. It will usually work one the second deck load, as the BPM information of the previously loaded track (in this example, the same) remains visible

BPM information gets updated by a CacheReader worker thread, once the file has started to be read