mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.52k stars 1.28k forks source link

Error with Stems in directories with special symbols (Addendum to #13550) #13783

Open Eve00000 opened 3 weeks ago

Eve00000 commented 3 weeks ago

Bug Description

I wanted to reorganize my library, put stems at the same place of the original. Importing the stem is no problem, opening (analyzing or player) makes Mixxx crash.

Deduction of the problem learns: F:\Music#0500 - Artists\Anne Clark\Anne Clark - Best Of Anne Clark (1992)\19 Anne Clark - Our Darkness (12).stem.m4a plays perfect, analazer, deck, sampler ... F:\Music#0500 - Artists\Anne Clark •\Anne Clark - Best Of Anne Clark (1992)\19 Anne Clark - Our Darkness (12).stem.m4a makes Mixxx crash. Normal ALAC files in this directory play fine.

The difference betweeb the 2 locations is the " •" after the name in the artist directory (to mark a directory as a Artist Container).

I compaired src\sources\soundsourceffmpeg.cpp src\sources\soundsourceflac.cpp src\sources\soundsourcemp3.cpp src\sources\soundsourcestem.cpp src\sources\soundsourceopus.cpp src\sources\soundsourcewv.cpp src\sources\soundsourcem4a.cpp they all have a different way to translate the location, I will highlight the windows lines

M4A: m_hFile = MP4Read(getLocalFileName().toUtf8().constData(), 0); Opus: QByteArray qBAFilename = getLocalFileName().toUtf8(); ... in some cases the filename is converted to utf8 and const, on otherr formats it isn't.

I played around with converting the "getLocalFileName()" without success. I think #13550 suffers of a similar problem. As I can remember 2.3.4 (or 5) had the same problem with " •" and other symbols for all files but the next release solved that. I tried to find the pr / solution but couldn't find it.

Version

2.5 & 2.6

OS

Win

Eve00000 commented 3 weeks ago

Solved in PR #13784