Recreate title bar for matching with skin colors

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.

http://mixxx.org

Other

4.53k stars 1.28k forks source link

Recreate title bar for matching with skin colors #13854

Open daschuer opened 2 weeks ago

daschuer commented 2 weeks ago

Feature Description

Many applications like Firefox the Gnome Terminal, VS-Code have replaced the system title bar with their own implementation to color it pleasant and make use of the unused space.

grafik

We should do the same with Mixxx

Swiftb0y commented 2 weeks ago

fyi this is a rabbit hole especially under wayland and the different linux desktop environments. Expect similar bugs and implementation differences as with the window menu...

Swiftb0y commented 2 weeks ago

also fyi, the technical term is "client-side window decoration". Potentially helpful: https://www.qt.io/blog/custom-window-decorations

ronso0 commented 3 days ago

It looks like it's not possible to style the QWidget legacy skins' main window's titlebar with Qt5, only subwindows https://doc.qt.io/qt-5/qstyleoptiontitlebar.html#details

For QML it's apparently possible via the ApplicationWindow element (not verified).

acolombier commented 3 days ago

I would second @Swiftb0y's comment here and suggest we act carefully here as these Wayland windows decoration is quite fragile across DE. Looking around, I found a Qt module that could help to better integrate with Adwaita/Gnome DE. Perhaps we could use this approach? Not sure if there is some similar module available for KDE.

daschuer commented 3 days ago

Nice, the related blog post is here: https://jgrulich.cz/tag/qadwaitadecorations/