search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.55k stars 1.29k forks source link

allow to bind `end_of_track` warning to `outro_end` #13970

Open ronso0 opened 20 hours ago

ronso0 commented 20 hours ago

Feature Description

Of course the end_of_track warning is helpful. Though there are certain tracks that "end" way earlier, ie. the last audible sound (-60 dB?) is significantly before the track end, so the warning threshold of let's say 30 sec might be just 10 sec before the track fades to silence.

It would be great if we could choose to bind "end" to outro_end, ie. activate the end_of_track warning N seconds before outro_end.

Extra benefit would be that we could use outro_end + end_of_track to avoid the hidden 'appendix' of certain tracks (vocals, noise, nonsense) and set the outro_end where the track should end.

acolombier commented 12 hours ago

I like this feature! Perhaps this is something we would want to keep configuration in the settings to allow users that prefer the current behaviour but I think the approach you are suggesting should be the default.

ronso0 commented 9 hours ago

Yes, I think an option is desired. Though, I think silently defaulting to outro_end on upgrade might surprise users.

daschuer commented 8 hours ago

Is there a use case to have the track end warning after the track is silence? Probably not, so I think we may take the risk do just implement this without a preference option. If anyone complains during beta period we can revise the decision.

ronso0 commented 8 hours ago

You're probably right. It's just that it'll be surprising to see the warning if you set it to 30 sec before end and the "remaining time" display shows e.g. 40 sec. And since the deck won's top, end_of_track should of course remain active after outro_end.