search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.5k stars 1.28k forks source link

New hotcues need scripting on Hercules Mk2 #5606

Closed mixxxbot closed 2 years ago

mixxxbot commented 2 years ago

Reported by: iltony Date: 2010-10-23T21:39:30Z Status: Fix Released Importance: Wishlist Launchpad Issue: lp665714 Attachments: hotcues-4-hercules-Mk2-iltonys.patch

Hotcues work great through mixxx interface, but no midi mapping exists yet for Hercules Mk2. I propose to enable them through the attached patch in the script "Hercules-DJ-Console-Mk2-scripts.js" located under "/usr/local/share/mixxx/midi". My script is organized so that:

1.(in cue mode) each button is assigned to 1,2,3 hotcue

  1. if first hotcue is no set, when users release button 1 a new hotcue is created
  2. when 1 is pressed again, the playback seeks to hotcue 1
  3. when 1 is long-pressed (more than half a second), first hotcue is cleared

Proposed patch works great on mixxx.1.8.x, Antonio

mixxxbot commented 2 years ago

Commented by: iltony Date: 2010-10-23T21:39:30Z Attachments: hotcues-4-hercules-Mk2-iltonys.patch

mixxxbot commented 2 years ago

Commented by: bkgood Date: 2011-01-01T23:57:54Z

Hi iltony,
Thanks for the patch! I just committed it to lp:mixxx/1.9. I noticed what I thought might be a bug, it looked like the timers used to detect when to delete weren't deck-specific, so I tried to make them so. Specifically, I added [Channel1] and [Channel2] indices to  curLastDate{1,2,3}. Would you mind trying this out and making sure it works for me (I don't have the controller)? I'd like to have this confirmed working by release of 1.9.

Bill

mixxxbot commented 2 years ago

Commented by: iltony Date: 2011-01-02T13:05:37Z

scons-ing right now.

mixxxbot commented 2 years ago

Commented by: iltony Date: 2011-01-02T22:18:18Z

Great. This new feature works fine in mixxx 1.9.0 branch with a Hercules Mk2! Now I'm thinking about adding other features as well: switching between "master tempo" and "pitch" mode, and a "reset pitch value" switch (might it be a good idea to associate this last action with a contemporary press of both pitch bend up and pitch bend down?) , but the main ones are there. Nice work btw! Quite impressed by this later improved library.

mixxxbot commented 2 years ago

Issue closed with status Fix Released.