search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.52k stars 1.28k forks source link

ID3 Tags are not written to file (1.9.0 beta1) #5711

Closed mixxxbot closed 2 years ago

mixxxbot commented 2 years ago

Reported by: toomuch Date: 2010-12-11T12:48:33Z Status: Invalid Importance: Undecided Launchpad Issue: lp688921 Attachments: bug, bug, tagoptions.jpg

I've tried fields: artist, rating, track and checked with Windows Explorer and MP3Tag v2.46a.

Have Win7 x64 and installed the beta without deinstalling the last stable version.

mixxxbot commented 2 years ago

Commented by: raffitea Date: 2010-12-11T13:42:43Z

Please make sure you have activated the check box for ID3 tag synchronization in the library preferences.

mixxxbot commented 2 years ago

Commented by: toomuch Date: 2010-12-11T14:06:35Z

Checked!

Is there anything else I need to do than clicking "Apply"?

mixxxbot commented 2 years ago

Commented by: raffitea Date: 2010-12-11T14:20:35Z

That's all. Does it work for you now? Can I mark the bug as invalid?

mixxxbot commented 2 years ago

Commented by: toomuch Date: 2010-12-11T22:01:52Z

Not now, not earlier. Sorry.

The check box was already checked! I tried it again, with no success. This time I changed the "year" (which should have that name and NOT date!!), clicked "Apply". After this I checked the properties againg and the change was gone.

mixxxbot commented 2 years ago

Commented by: raffitea Date: 2010-12-11T23:34:51Z

Sorry for asking again... I'm a bit confused...

Am I right that you use track properties dialog to change the metadata?

At the moment Mixxx writes metadata if you change the field by using a single click on a table cell item.

mixxxbot commented 2 years ago

Commented by: toomuch Date: 2010-12-12T09:13:51Z

Hey!

I tested both methods. Track properties dialog and table cell item. Both ways I get not the expected result.

EDIT:

Wow! Now it worked. First I thought Mixxx erased all data..But it just stored it in ID3 v2.4 which Windows Explorer does not support yet. Could you build an option to choose which Tag Version one wants to use?

EDIT2: Tried it again. Didn't work. Somehow it seems not to be consistent.

mixxxbot commented 2 years ago

Commented by: raffitea Date: 2010-12-12T16:08:36Z

By default, ID3v2 comments are written to the mp3 files. As long as these information are reflected tools like Mp3Tag everything is ok. I've similar problems with my Windows Explorer. All my files are manupulated with Mp3Tag, but the Explorer fails in reading the tags for various files.

You can open the log file to see if metedata has been written successfully to the file.

I could implement an option such that the old ID3v1 tag is written as well. But I think it does not make sense because good music players such as iTunes can handle Id3v2 and up.

BTW: Some fileds are not written to file:

All other metadata be synchronized.

mixxxbot commented 2 years ago

Commented by: toomuch Date: 2010-12-12T20:00:41Z Attachments: bug

Windows Explorer can only read to ID3v2.3, Mixxx writes ID3v2.4. No need to write ID3v1, but ID3v2.3 would be nice (#option). (For the record: iTunes is not a good music player! At least on Windows it sucks! That might be intended by Apple...)

But again, it sometimes works, sometimes not. I tried it again (see screenshots). Didn't work.

(Can't find the log file: http://mixxx.org/wiki/doku.php/reporting_bugs?s[]=log.Isn't under C:\Program Files\Mixxx...)
mixxxbot commented 2 years ago

Commented by: toomuch Date: 2010-12-12T20:07:09Z Attachments: bug

LOL! Nice woman, but this time you'll have the right attachment. :)

mixxxbot commented 2 years ago

Commented by: raffitea Date: 2010-12-12T20:41:00Z

Mixxx should at least write meatadata when it closes. Try to refresh the Mp3Tag view. It has worked fine on my machine.

We use a foreign library called taglib to support metadata writing. It does only support id3v1 and id3v1 comment on Mp3. Mixxx can't write ID3v3 or ID3v4 comments

mixxxbot commented 2 years ago

Commented by: toomuch Date: 2010-12-13T00:59:02Z Attachments: tagoptions.jpg

I see, you need to close Mixxx in order to save the changes. It finally works. (Saving the changes immediately would be better in my perpective.)

Bug can be marked invalid. At some point in the wiki it should be mentioned that you need to close Mixxx to save the changes. This just doesn't feel normal.

You are messing up the Versions. Mixxx writes: v1 and v2.4 (on my system). Windows Explorer only supports up to v2.3. So it would be nice to have an option to choose what version of tag shall be written to the file (see attachment). Otherwise Win7 Users have no MP3-Tags in Windows Explorer.

mixxxbot commented 2 years ago

Commented by: raffitea Date: 2010-12-13T07:49:20Z

I know that other DJ software systems write metadata immediately after a change. This may lead to failures sometimes. In particular, you can't write metadata to a file that has been loaded to a deck and thus is read incrementally. We bypass the problem by writing at the end of a session.

To be honest, there's no big difference between ID3v2.x series. I'll try to find out how I can force ID3v2.3 versions. But maybe taglib -- the library we use for tagging -- does not provide such a possibility.

mixxxbot commented 2 years ago

Commented by: toomuch Date: 2010-12-19T20:52:35Z

"particular, you can't write metadata to a file that has been loaded to a deck and thus is read incrementally."

I can play a file with VLC and edit the Tag with MP3Tag with no problems.

"To be honest, there's no big difference between ID3v2.x series." The main difference for me is that v2.4 is not supported by Windows Explorer. That's not your fault of course.

Did you figure out if the taglib supports writing v2.3?

mixxxbot commented 2 years ago

Issue closed with status Invalid.