search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.52k stars 1.28k forks source link

changing terminology "Remove" to "Hide" #6298

Closed mixxxbot closed 2 years ago

mixxxbot commented 2 years ago

Reported by: ronald-delvax-hotmail Date: 2012-03-08T10:47:33Z Status: Fix Released Importance: Low Launchpad Issue: lp949828 Attachments: hide.patch, hide2.patch, hide4.patch, hide5.patch, hideImprovment.patch

In 1.10 (using Ubuntu) I accidentally deleted my library files. After I rescanned the library, it still doesn't get my library back. It even removed ALL the playlist and crates content! Thankfully, the files are not deleted...

mixxxbot commented 2 years ago

Commented by: daschuer Date: 2012-03-08T19:12:26Z

This looks like the "desired" behavior of Mixxx. Is it this what happens?:

The only workaround I know for this case now, is to use Ubuntu's "Search for files" feature and Drop all files back to the library view. This must be a bitchy task if you have a big library.

Mixxx misses an "Undelete all" function. This could be placed in the application's menu bar.

mixxxbot commented 2 years ago

Commented by: rryan Date: 2012-03-08T19:38:43Z

Daniel is right -- when you delete tracks from the library we mark them deleted so they do not show up on a re-scan. If you ask us to remove a track from the library you might be annoyed if they all came right back after a re-scan.

The only work-around is that we un-delete tracks when you drag them back into the library from a file browser.

I agree with Daniel -- we need some way for the user to ask us to undelete everything.

2012/3/8 Daniel Schürmann <email address hidden>

This looks like the "desired" behavior of Mixxx. Is it this what happens?:

  • Slect Library view
  • Ctrl+A
  • delete tracks via context menu. This clears all playlists an crates content as well This marks all tracks as deleted
  • rescan library
  • The library scanner discards all found songs because the are marked as deleted.

The only workaround I know for this case now, is to use Ubuntu's "Search for files" feature and Drop all files back to the library view. This must be a bitchy task if you have a big library.

Mixxx misses an "Undelete all" function. This could be placed in the application's menu bar.

-- You received this bug notification because you are a member of Mixxx Development Team, which is subscribed to Mixxx. https://bugs.launchpad.net/bugs/949828

Title: Rescan library doesn't work

To manage notifications about this bug go to: https://bugs.launchpad.net/mixxx/+bug/949828/+subscriptions

mixxxbot commented 2 years ago

Commented by: ywwg Date: 2012-03-08T20:03:21Z

I've been confused about the "delete" terminology myself, so maybe we should change it. How about calling these tracks "hidden" instead. Then we can make a special library view that shows only the hidden tracks. The user can go into this view, select the tracks, and unhide them.

mixxxbot commented 2 years ago

Commented by: ronald-delvax-hotmail Date: 2012-03-08T22:38:08Z

Where does Mixxx keep track of settings like this? I'm not yet too familiar with Linux to find files like that...

I also found a problem when I try to drag the width of a section in a list... It automatically creates a space that I can't delete... By manually edditing the settings I might correct this... 1.8 didn't have this problem tho... And 1.10 on Windows has the same problem.

BTW, thanx for the quick reply.

mixxxbot commented 2 years ago

Commented by: daschuer Date: 2012-03-09T19:48:00Z

@Owen: I like your idea to change the naming to "hide" and have a tree view child for "Hidden tracks".

@Angel: Mixxx keeps its library at ~/.mixxx/mixxxdb.sqlite. If you are brave enough, you may install sqlitebrowser and "unhide" the tracks manually due to to reset the value of "mixxx_deleted" in the "library" table to 0. Please exit mixxx first and don’t forget to backup the mixxxdb.sqlite file.

The collumn resize issue is tracked in bug #⁠925619. You may klick that this bug effects you too.

mixxxbot commented 2 years ago

Commented by: daschuer Date: 2012-03-31T13:35:50Z Attachments: hide.patch

The attached patch renames "Remove" into "Hide from library" and it introduces "purgeTracks" for remove track from missing tracks view and from browser view.

mixxxbot commented 2 years ago

Commented by: daschuer Date: 2012-04-18T20:44:07Z Attachments: hide2.patch

Updated patch for lp:mixxx #⁠3023 Additional removed unused functions.

mixxxbot commented 2 years ago

Commented by: daschuer Date: 2012-06-11T06:01:16Z

Hi Max,

I am please that you pickup this one. I am just wondering whats the best time line for it. Since this bug is a Milestone 1.11 fix and you are panning to add additional features which will take place in a later milestone. Do you think its possible to prepare a "preview" based on the current patch that is suitable for 1.11 but dos not complicate your planed work?

Kind regards

Daniel

mixxxbot commented 2 years ago

Commented by: kain88-de Date: 2012-06-11T20:51:05Z

I don't know when RJ wants to start the beta-phase for 1.11 so I can't say for sure.

For 1.11 I could imagine to add a hiddenTM and add a undo option for this TM in addition to your patch (see #⁠406365) to wrap this one up nicely. If you can give me a patchfile of your work on a undo function this should be manageable in the next 1-2 weeks and also helpful for me on my work for 1.12.

mixxxbot commented 2 years ago

Commented by: kain88-de Date: 2012-06-13T07:46:13Z Attachments: hide4.patch

OK this was done faster then I thought.

This patch against trunk r. 3254

It adds a hiddentablemodel that is shown as a in addition to the missingtablemodel. In this TM it's possible to unhide the tracks or purge them. Also I've changed "Remove" in the missingTM to "Purge from Library", this is because we also use "Remove" in Playlists and Crates but there "Remove" does not mean delete this track from the library and in the context of the hiddenTM and missingTM it should be clear what purge means. The rest is from Daniels patch

mixxxbot commented 2 years ago

Commented by: daschuer Date: 2012-06-14T12:58:56Z

Hi Max,

Good work!

I head a little time for test. Here are my results:

mixxxbot commented 2 years ago

Commented by: rryan Date: 2012-06-14T18:01:04Z

Just took a quick pass over the code and it looks good to me. I'll give it a more thorough review later.

In TrackDAO::purgeTracks make sure to use ScopedTransaction instead of manually beginning and rolling back in every error case.

mixxxbot commented 2 years ago

Commented by: kain88-de Date: 2012-06-19T19:01:38Z Attachments: hide5.patch

This version uses ScopedTransactions, please comment if I've used it correctly

All references I've found in the library are also deleted. If the track is in a subdir of libraryPath the track will be added on the next rescan.

Show in Browser now falls back to the home directory in case the file is not found. I'd prefer to use QDir::cdUp() but this will do nothing if the directory still does not exist.

I have a question about performance. I see a lot that we use QString(...).arg and "..." + variable a lot which one of these is faster? If one has a performance benefit we should stick to that one. This is important since we handle a lot of our DB-code in the GUI-Thread.

mixxxbot commented 2 years ago

Commented by: rryan Date: 2012-06-20T15:38:02Z

Thanks Max! I reworked your patch a little bit in purgeTracks(). Also I moved hideTracks() to BSTM instead of LibraryTableModel since hiding from crates / playlists / analyze / etc. doesn't work otherwise.

mixxxbot commented 2 years ago

Commented by: kain88-de Date: 2012-06-21T16:07:53Z Attachments: hideImprovment.patch

This addresses the TODO's you've added

mixxxbot commented 2 years ago

Commented by: rryan Date: 2012-06-21T16:56:12Z

Thanks -- committed.

mixxxbot commented 2 years ago

Issue closed with status Fix Released.