search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.41k stars 1.26k forks source link

Rename master/headphone volume to gain. #7413

Closed mixxxbot closed 2 years ago

mixxxbot commented 2 years ago

Reported by: daschuer Date: 2014-04-10T20:56:16Z Status: Fix Released Importance: Low Launchpad Issue: lp1306253

Since [Master],volume is a multiplier to the samples, it behaves like a bit crusher.

The name implies, that is is a volume control of the master output. Instead it is an output gain.

If people using it for lets say play background music during a dinner, it is actually a bitcrusher.

Related post: http://music.columbia.edu/pipermail/portaudio/2011-January/011366.html

mixxxbot commented 2 years ago

Commented by: daschuer Date: 2014-04-22T18:02:50Z

Bug #⁠1280771 issues the input mixer

mixxxbot commented 2 years ago

Commented by: rryan Date: 2014-11-26T19:50:48Z

So should we deprecate the volume control, rename it to "gain" and alias "volume" to it for backwards compatibility?

Your bug title suggests we should remove master gain -- sure people should ideally not reduce the fidelity of their music before it gets converted to analog (unless it's clipping) but the live broadcasting and recording crowd at least need a handy gain knob. And many DJs will want it for the convenience even though it is less ideal than doing it with the club mixer.

mixxxbot commented 2 years ago

Commented by: daschuer Date: 2014-11-26T20:13:40Z

Rename it to [Master]gain would be technically correct and a good idea.

Anny Idea about the effort to control the sound cards volume?

mixxxbot commented 2 years ago

Commented by: rryan Date: 2014-11-27T04:39:56Z

Renaming to "gain" and aliasing to "volume" sounds good -- I think we should leave soundcard settings alone though.

mixxxbot commented 2 years ago

Commented by: rryan Date: 2014-11-28T19:05:42Z

https://github.com/mixxxdj/mixxx/commit/23823f529f728164e17fa977c23f3b8d24fce9dc

Updated skins, tooltips, control picker.

mixxxbot commented 2 years ago

Commented by: Be-ing Date: 2015-07-29T05:24:46Z

I noticed that the control objects [Master],volume and [Master],headVolume have not been renamed. Should they be renamed and the old names deprecated and aliased to new names?

mixxxbot commented 2 years ago

Commented by: daschuer Date: 2015-07-29T05:58:41Z

Thats already done, in Mixxx: https://github.com/mixxxdj/mixxx/blob/da0f31cd220c3ad878367a5abe14044812afeb44/src/engine/enginemaster.cpp#L108

Where did you find it? Maybe we should mark them as deprecated there.

mixxxbot commented 2 years ago

Issue closed with status Fix Released.