mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.51k stars 1.28k forks source link

Eq Presets #7573

Open mixxxbot opened 2 years ago

mixxxbot commented 2 years ago

Reported by: ferranpujolcamins Date: 2014-09-09T04:27:29Z Status: Confirmed Importance: Wishlist Launchpad Issue: lp1367092 Tags: eq


EQ options are growing in number as for Mixxx 1.12. However most users don't care about Butterworth, 24 db/oct, resonance or whatever. They care about how the EQ behaves or whether we have that mixer brand EQ or not.

So I think EQ advanced options should be hidden behind presets. So in preferences, the user is presented with a set of EQ presets and he/she can choose between a full kill EQ, soft EQ, Xone 92 EQ, Pioneer DJM-900 EQ, etc. If a user wants advanced fine control over the EQ, he/she can just add or edit a preset and choose among the different EQ types we offer and its options.

This also allows a DJ to have several saved fine-tuned EQ's for different occasions and change between them quickly.

mixxxbot commented 2 years ago

Commented by: daschuer Date: 2014-09-09T06:45:49Z


Hi Ferran,

Yes, i am also heading to a limited well suited set of EQs.

But we have also head the discussion of using marketing names or programmatic names for our EQs. The decision was to use the programmatic words like "Linkwitz-Riley". https://github.com/mixxxdj/mixxx/pull/268

full kill EQ, soft EQ, Xone 92 EQ, Pioneer DJM-900 EQ

There is already pending discussion about the final set of EQs. What is your favorite set? Can you describe the EQs listed above? Xone 92 EQ is already here: https://bugs.launchpad.net/mixxx/+bug/1366680

Thank you,

Daniel

mixxxbot commented 2 years ago

Commented by: ferranpujolcamins Date: 2014-09-09T08:16:11Z


The names and EQ types I described here were just meant to be an example to illustrate my point. Not that I feel they should be implemented (maybe I do for some of them, but that's not what I want to stress here)

The important idea here is the EQ Presets.

For me what it's important is the possibility to customize the EQ. Asymmetric gain/cut levels, cut-off frequencies, number of bands, knob curve response, roll-off, filter type per band...The more the better. Presets would be a handy feature to hide the EQ's complexity to non technical users while also allowing EQ config recall.

If EQ options are wide enough, we don't probably need many EQ types (low-cpu and high-cpu ones?). If someone wants an EQ similar to the Xone 92's one, just create a new preset and tweak it as needed. Presets could also be imported/exported, so we could just provide with a few useful presets and let users share their own.

To summarize: highly customizable EQ with ready-to-go presets to hide complexity.

mixxxbot commented 2 years ago

Commented by: daschuer Date: 2014-09-09T10:35:17Z


It is possible to make one fully parametric EQ like you suggested. But only for one Class of EQ at a time.

It would be hard to make turn a Butterworth8 EQ into a Xone 92 EQ, because of the completely different back-end (Wiring of the Atomic Filters and the Math involved)

We have already a request for a 5 Band parametric EQ focusing Master EQ (Sound System Compensation) https://bugs.launchpad.net/mixxx/+bug/1364779

We may add a parametric EQ as a Mixing EQ as well. But I am in doubt if it is worth the work. I would prefer to build an "Ferran" EQ, that is pre-tweaked as you need it. Can you describe the properties?

But a fully tweak-able version is also welcome. Are you able to prepare a pull request for such an EQ? You will receive all the help you need.

mixxxbot commented 2 years ago

Commented by: ferranpujolcamins Date: 2014-09-09T11:02:59Z


It would be hard to make turn a Butterworth8 EQ into a Xone 92 EQ, because of the completely different back-end

However, sticking with the same EQ type, it is possible to have a low band with 24 db/oct roll-off and a hi band with 12 db/oct, right? I've seen a crossover vst plugin that allows this.

I would prefer to build an "Ferran" EQ, that is pre-tweaked as you need it. Can you describe the properties?

I truly appreciate your interest! I think a 4-band xone 92 style EQ is a good compromise between something I like and somethin other people could also like. Also, its no full kill mid bands offer a good alternative to the total kill classic Mixxx EQ.

Are you able to prepare a pull request for such an EQ? You will receive all the help you need.

I'm really tempted. Again, thanks for your implication, but please keep in mind that that this means A LOT of help I'll need :). I've got a lot to learn about Mixxx's internals and signal processing. Also, forget about getting it for 1.12.

We have already a request for a 5 Band parametric EQ focusing Master EQ Shouldn't the same parametric EQ implementation be used for master output and as a mixing EQ?

mixxxbot commented 2 years ago

Commented by: daschuer Date: 2014-09-09T12:34:21Z


However, sticking with the same EQ type, it is possible to have a low band with 24 db/oct roll-off and a hi band with 12 db/oct, right? I've seen a crossover vst plugin that allows this.

It depends on the EQ type and if Neutral at 0 Gain is important might be hard. Do you have a link to the vst plugin?

Also, its no full kill mid bands offer a good alternative to the total kill classic Mixxx EQ.

We can allow total Kill at Mid and rename it.

We have already a request for a 5 Band parametric EQ focusing Master EQ

Shouldn't the same parametric EQ implementation be used for master output and as a mixing EQ?

It has 15 Knobs. A bit too much for a Mixing EQ :-) Mixing EQs are more "effecty" like total kill and so on where Master EQ should allow to fix sound-system and other static problems.

--

If you like to make your hands dirty. You can start here: http://www.mixxx.org/wiki/doku.php/bugfix_workflow Your work will be quite similar to: https://github.com/mixxxdj/mixxx/pull/303/files

mixxxbot commented 2 years ago

Commented by: ferranpujolcamins Date: 2014-09-09T12:51:13Z


Yeah but for the mixing EQ you make just the gain knobs go to the GUI and the rest are the parameters you adjust once in preferences. Maybe some of the code is reusable don't know. Will think abou it :)

2014-09-09 14:34 GMT+02:00 Daniel Schürmann

However, sticking with the same EQ type, it is possible to have a low band with 24 db/oct roll-off and a hi band with 12 db/oct, right? I've seen a crossover vst plugin that allows this.

It depends on the EQ type and if Neutral at 0 Gain is important might be hard. Do you have a link to the vst plugin?

Also, its no full kill mid bands offer a good alternative to the total kill classic Mixxx EQ.

We can allow total Kill at Mid and rename it.

We have already a request for a 5 Band parametric EQ focusing Master EQ

Shouldn't the same parametric EQ implementation be used for master output and as a mixing EQ?

It has 15 Knobs. A bit too much for a Mixing EQ :-) Mixing EQs are more "effecty" like total kill and so on where Master EQ should allow to fix sound-system and other static problems.

--

If you like to make your hands dirty. You can start here: http://www.mixxx.org/wiki/doku.php/bugfix_workflow Your work will be quite similar to: https://github.com/mixxxdj/mixxx/pull/303/files

-- You received this bug notification because you are subscribed to the bug report. https://bugs.launchpad.net/bugs/1367092

Title: Eq Presets

Status in Mixxx: Confirmed

Bug description: EQ options are growing in number as for Mixxx 1.12. However most users don't care about Butterworth, 24 db/oct, resonance or whatever. They care about how the EQ behaves or whether we have that mixer brand EQ or not.

So I think EQ advanced options should be hidden behind presets. So in preferences, the user is presented with a set of EQ presets and he/she can choose between a full kill EQ, soft EQ, Xone 92 EQ, Pioneer DJM-900 EQ, etc. If a user wants advanced fine control over the EQ, he/she can just add or edit a preset and choose among the different EQ types we offer and its options.

This also allows a DJ to have several saved fine-tuned EQ's for different occasions and change between them quickly.

To manage notifications about this bug go to: https://bugs.launchpad.net/mixxx/+bug/1367092/+subscriptions

-- Ferran Pujol Camins