search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.5k stars 1.28k forks source link

Separate color config for RGB waveform renderer #7594

Closed mixxxbot closed 2 years ago

mixxxbot commented 2 years ago

Reported by: zezic Date: 2014-10-03T02:30:39Z Status: Fix Released Importance: Wishlist Launchpad Issue: lp1376989 Tags: skin, waveform

Waveforms in Mixxx have color configs:
<SignalHighColor></SignalHighColor>
<SignalMidColor></SignalMidColor>
<SignalLowColor></SignalLowColor>

but with RGB renderer colors get mixed another way, so i think separate color config for RGB renderer needed. Something like:
<RGBHighColor></RGBHighColor>
<RGBMidColor></RGBMidColor>
<RGBLowColor></RGBLowColor>
mixxxbot commented 2 years ago

Commented by: esbrandt Date: 2014-10-31T19:07:20Z

FWIW, the actual keys to use are
<SignalRGBLowColor>/<SignalRGBLowColor>
<SignalRGBMidColor>/<SignalRGBMidColor>
<SignalRGBHighColor>/<SignalRGBHighColor>

Works with RGB (GL) waveforms exclusively Preferences>Waveforms>Summery Type>RGB (GL)

mixxxbot commented 2 years ago

Commented by: esbrandt Date: 2014-10-31T19:08:17Z

Where is the edit button :)
<SignalRGBLowColor></SignalRGBLowColor>
<SignalRGBMidColor></SignalRGBMidColor>
<SignalRGBHighColor></SignalRGBHighColor>
mixxxbot commented 2 years ago

Commented by: ninomp Date: 2014-11-30T19:55:39Z

Should I fix this in non-GL RGB waveform renderer as well?

mixxxbot commented 2 years ago

Commented by: daschuer Date: 2014-11-30T20:22:12Z

I think no, unless there a special use case for this.

I think the main difference is: RGB -> all colors are possible due to the mix. Non RGB, only the given colors are used. So both cases are covered.

mixxxbot commented 2 years ago

Commented by: esbrandt Date: 2014-12-03T10:24:24Z

We are talking about the NON-GL RGB waveform renderer, correct?

I`d say yes, it makes sense to make the <SignalRGB$Color> work there too, because one can assume the selected colors work across all available RGB renderers. Then the wishlist bug is nailed down.
mixxxbot commented 2 years ago

Commented by: zezic Date: 2015-02-23T19:36:16Z

Please, add this option for overviews too.

mixxxbot commented 2 years ago

Commented by: ninomp Date: 2015-02-24T17:28:59Z

OK I'll get on it.

mixxxbot commented 2 years ago

Commented by: ninomp Date: 2015-03-03T01:30:39Z

Done - https://github.com/mixxxdj/mixxx/pull/508

mixxxbot commented 2 years ago

Commented by: zezic Date: 2015-03-03T16:18:45Z

Thanks!

mixxxbot commented 2 years ago

Issue closed with status Fix Released.