mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.45k stars 1.27k forks source link

remove "master mix" option #7607

Open mixxxbot opened 2 years ago

mixxxbot commented 2 years ago

Reported by: Be-ing Date: 2014-10-14T21:00:18Z Status: Confirmed Importance: Wishlist Launchpad Issue: lp1381226


Currently, 1.12 has "Master Mix" (Enabled/Disabled) and "Master Output Mode" (Stereo/Mono) fields in the Sound Hardware configuration dialogue. I don't see the need for either of these fields. Regarding the "Master Mix" field, if one wants to turn off the master mix, then simply select "None" for the master output. Regarding the "Master Output Mode" field, Mixxx should automatically output in mono when a single channel is selected and in stereo when a pair of channels is selected. Perhaps I'm lacking imagination, but I can't think of a case when it would be useful to output to a pair of channels in mono. If there is no need for the ability to do this, then there is no need for the "Master Output Mode" field. Keeping these fields on the dialogue is unnecessary clutter.

mixxxbot commented 2 years ago

Commented by: ywwg Date: 2014-10-14T21:19:59Z


Outputting two mono channels is often needed for certain really crappy venues that downmix everything to mono from stereo -- if you don't provide both channels the mains levels would be half what they should be.

Removing Master Mix might be possible

mixxxbot commented 2 years ago

Commented by: Be-ing Date: 2014-10-15T03:05:17Z


If the venue downmixes everything to mono from stereo, wouldn't outputting to stereo sound the same as outputting two mono channels?

mixxxbot commented 2 years ago

Commented by: daschuer Date: 2014-10-15T05:51:51Z


I agree that these options are somehow confusing. So any Ideas to improve that are welcome.

We have use cases for "Master Mix" = enabled and "Master" = Non, because the master mix can be recorded, broadcasted and Mixed to headphone .

Mixxx has already automatically output in mono when a single channel is selected. A two channels mono output is required, for outdoor gigs, where L and R speakers are installed in different places. A Single channel output would require a splitter cable here to feed the mono channel to L and R Amp.

mixxxbot commented 2 years ago

Commented by: daschuer Date: 2014-10-15T06:03:05Z


wouldn't outputting to stereo sound the same as outputting two mono channels?

It depends on the played track. For Creedence Clearwater Revival - Susie Q it is not the case.

mixxxbot commented 2 years ago

Commented by: Be-ing Date: 2014-10-17T06:47:06Z


We have use cases for "Master Mix" = enabled and "Master" = Non, because the master mix can be recorded, broadcasted and Mixed to headphone .

In those cases, could the master mix be automatically turned on when necessary even if it is not outputting to any sound card? That would eliminate the need for the "Master Mix" option in the GUI.

mixxxbot commented 2 years ago

Commented by: daschuer Date: 2014-10-17T07:13:34Z


This might be possible. But How to decide if we need the Master Mix for headphones?

mixxxbot commented 2 years ago

Commented by: ywwg Date: 2014-10-17T13:16:35Z


How much CPU are we really saving by having the option to disable the Master Mix? It seems like a lot of complexity for something most people will never care about. (Most of our CPU goes toward EQ -- I don't think adding streams together could possibly be significant)

mixxxbot commented 2 years ago

Commented by: daschuer Date: 2014-10-17T14:33:58Z


I have not measure the CPU saving.

This was a fix for this Bug #⁠1269139 And yes, it is a rare use case and saves only some CPU.

mixxxbot commented 2 years ago

Commented by: Be-ing Date: 2014-10-17T19:02:55Z


If the master/headphone mix is all the way down or there is no output to headphones, the master mix could be turned off.

mixxxbot commented 2 years ago

Commented by: rryan Date: 2014-11-18T07:05:58Z


So, it sounds like there is a rare but valid reason for mono downmix.

The master mix preference option was added because we can't tell whether the master is needed. So I'll re-name this bug to be dedicated to being able to tell when the master output is needed:

Cases: 1) When a sidechain worker is active. 2) When a master output is enabled.

As for the head/master corner case -- I'm for making that knob do nothing if no master output is enabled.