search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.45k stars 1.27k forks source link

Remove a track from a crate triggers sorting #7619

Open mixxxbot opened 2 years ago

mixxxbot commented 2 years ago

Reported by: jclaveau Date: 2014-10-29T20:49:34Z Status: Confirmed Importance: Low Launchpad Issue: lp1387373 Tags: library

I often sort my tracks by number of stars to evaluate/rate them.

If I give, for example 3 stars to a non-rated track and then remove another one from the crate, all the crate list will be sorted, as if I had clicked on the column name.

It's a bit confusing even if not blocking.

mixxxbot commented 2 years ago

Commented by: davidchocholaty Date: 2022-04-08T07:40:40Z

I will try to take a look on it.

mixxxbot commented 2 years ago

Commented by: davidchocholaty Date: 2022-04-11T06:58:44Z

The problem is a little bit more broader. It can be seen in crates, tracks and playlists too. Every time you choose the rating column for sorting (ascending or descending, doesn't matter), than do some changes on star rating and than after action as remove track, add track, switch window between crates and tracks for example, a table is sorted by selected column and order. In my opinion, I agree that user expected behaviour especially when removing the track is, that the table is being unchanged. With adding a track to crate, the track will be added at the end of the tracks table. Can more experienced mixxx developer confirm to me, that this change with disable sorting for the listed situations is required? Thank you in advance.

mixxxbot commented 2 years ago

Commented by: daschuer Date: 2022-04-11T08:33:20Z

Thank you for confirming. It sounds like this bug required deeper investigation to solve it. I suggest to use a debugger and set a breakpoint to the select() function and reproduce the error. One you hit the breakpoint investigate the backtrace to find out why that is triggered when a track is removed.