search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.51k stars 1.28k forks source link

bitcrusher not dry at center position #7759

Open mixxxbot opened 2 years ago

mixxxbot commented 2 years ago

Reported by: ywwg Date: 2014-12-22T14:21:12Z Status: Confirmed Importance: Low Launchpad Issue: lp1404901

Quick effects need to be uniform. Currently the bitcrusher is dry at the left position instead of the center, which is incorrect.

mixxxbot commented 2 years ago

Commented by: daschuer Date: 2014-12-22T15:08:31Z

Isn't this a duplicate for #⁠1404741?

What should be on the both sides of the filter knob?

mixxxbot commented 2 years ago

Commented by: ywwg Date: 2014-12-22T15:26:47Z

This bug is more specific to this one effect, whereas the other bug is asking about design questions that are more long term.

I would be ok with both sides of the bitcrusher being mirror images (dry to wet in either direction). Or, reduce bit depth on one side and reduce sample rate on the other side.

mixxxbot commented 2 years ago

Commented by: ywwg Date: 2014-12-23T14:06:39Z

I think we are out of time to design an elegant fix for this. For now I think we should just make a second quick-effect-specific version of the bitcrusher and put a big TODO on it to unify it with the regular bitcrusher.

mixxxbot commented 2 years ago

Commented by: daschuer Date: 2014-12-23T14:33:50Z

I would prefer to just add a second set of defaults to every effect, that is used when loading into the quick effect. There should be fragments of the load and Store code we may use. I have not ad a look to the code, maybe RJ can help here.

This will also allow to pick filters with different resonance. The current defaults are very decent.

By the way, I think pioneer combines the Bitcusher with the filter to generate two different sides of the Filter knob. If we decide for a second Bitcrusher, we may implement something like that.

mixxxbot commented 2 years ago

Commented by: ywwg Date: 2014-12-23T14:52:08Z

I just want to have one simple bandaid for this one effect for this one release, not add something new to every effect. We do not have time now to design a better solution for the general case.

mixxxbot commented 2 years ago

Commented by: ferranpujolcamins Date: 2015-06-24T22:57:51Z

+1 to pioneer like bitcrusher+filter

mixxxbot commented 2 years ago

Commented by: rryan Date: 2015-12-31T16:43:40Z

I think this is fixed, no?

mixxxbot commented 2 years ago

Commented by: daschuer Date: 2016-01-02T22:09:53Z

It is not solved for the quick effect. You can configure the Bitcrusher like that if you change the superknob mapping. This is only accessible in the effect racks of Shade and Deer

mixxxbot commented 2 years ago

Commented by: pestrela Date: 2020-04-29T23:42:46Z

still a problem in 2020

mixxxbot commented 2 years ago

Commented by: Be-ing Date: 2020-04-30T00:01:32Z

I don't agree that this is a problem. It wouldn't make sense to have a bipolar bitcrusher knob. Ferran proposed a combination bitcrusher + filter effect above, but that only works well with a low pass filter, not a high pass.

mixxxbot commented 2 years ago

Commented by: pestrela Date: 2020-04-30T12:24:21Z

my point is that I agree with this sentence: "Quick effects need to be uniform." This means that all quickfilters need to be dry at middle position

"You can configure the Bitcrusher like that if you change the superknob mapping." I think this is the root issue here: quickfilters is, AFAIK, only a shortcut to the effect mapping. I beleive the new FX feature can decouple this.