mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.43k stars 1.27k forks source link

Highlight search matches in Auto DJ list #7805

Open mixxxbot opened 2 years ago

mixxxbot commented 2 years ago

Reported by: naught101 Date: 2015-01-13T02:03:37Z Status: Confirmed Importance: Wishlist Launchpad Issue: lp1409996 Tags: autodj, library


It would be really good to be able to search/filter and sort the auto DJ list. Sometimes it would be useful to go through and remove all tracks from the list from a particular album, or genre, and there is no easy way to do this at the moment, because of the lack of these functions. Obviously, these functions should not affect the actual play order (which I assume is defined by the '#' column?), and it might make sense to have the filters/sorts reset whenever a track gets auto-added to a deck.

mixxxbot commented 2 years ago

Commented by: daschuer Date: 2015-01-13T07:39:30Z


Ad mentioned in Bug #6335 and Bug #6408 this was disabled by design.

We have also already discussed it in Bug #6090, but since you file it again it seams to be a real issue for you.

Your use case is valid. I think we can allow it by selecting the search matches. Would that help?

Since we "won't fix" the sorting, I like to change the Bug title to something we are able to do.

What about: "Select search matches in Auto DJ"

mixxxbot commented 2 years ago

Commented by: naught101 Date: 2015-01-14T22:11:10Z


Yeah, I figured there was a reason for it, but I tried searching, and nothing came up. And apparently I commented at #887811 before, so this has clearly been bugging me for a while ;) Sorry for the duplicate and my short memory.

Selecting might work, but I doubt it will be great - if the playlist is really long, it might be hard to see everything that's filtered. Also, often you want to filter on part of a name, and then delete only some tracks that match that search. I guess you could ctrl-click to deselect the tracks you want to keep, but it could still get unwieldy.

I wonder if it might be possible to make the #⁠2 track (next to play) special, and unaffected by the filter (so it always displays), and then automatically reset the filter when ever that track is loaded?

But yeah, if that's not possible, selecting would be better than nothing.

mixxxbot commented 2 years ago

Commented by: naught101 Date: 2018-01-05T01:49:27Z


From https://github.com/mixxxdj/mixxx/pull/1117#issuecomment-355331293

Sounds like it's probably too late to comment on the autoDJ search, but I personally would prefer to be able to search in AutoDJ. Would it be possible to leave it there, but change the functionality such that instead of only showing matching tracks, it instead greyed-out non-matching tracks, such that they couldn't be selected, but were still visible? This would make it useful for removing tracks from a full queue (e.g. search "genre:dubstep", ctrl+A in queue selects all dubstep tracks, right-click -> remove), without making the queue order confusing.

mixxxbot commented 2 years ago

Commented by: daschuer Date: 2018-01-05T06:17:42Z


Can we, remove sorting from the bug description and focus it to you latest ideas? Than I like to confirm it.

ronso0 commented 1 year ago

We could disable (grey out) tracks so they are still visible but not selectable IIUC. This could work like the filter in the Browse feature except that it doesn't hide the rows but sets the Qt::ItemFlags (Qt::ItemIsEnabled, Qt::ItemIsSelectable, `Qt::ItemIsEditable).