search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.47k stars 1.27k forks source link

Proposal: Only display track clipping when deck output is selected #7863

Open mixxxbot opened 2 years ago

mixxxbot commented 2 years ago

Reported by: ywwg Date: 2015-02-20T23:33:23Z Status: Opinion Importance: Wishlist Launchpad Issue: lp1424103

Since we use floating point samples, there is no clipping at the track level, so the clipping indicators are not really accurate. However they are accurate if the user has deck outputs selected. Therefore, perhaps we should not light the clipping indicators unless deck outputs are connected. I'm not sure if the right answer is to hide the clipping indicator, or just not light it up.

mixxxbot commented 2 years ago

Commented by: daschuer Date: 2015-02-21T07:10:56Z

I would like to keep them. Using Mixxx in a way that internal sample values are above one is not the normal case we develop against. All instances in the engine chain assume that the samples are below 1. We cannot grantee that the samples are not clamped once we starting to use effect plug-Ins.

You are right, that deck clipping is not a real issue right now as long the master output does not clip.

For me the deck clipping lights a helpfull indicator when tweaking gain and EQs in PFL mode.

If you use no mixing headroom by setting the master gain to 0 dB. A clipping deck will immediately be clamped when mixed to the master. So It is a good idea to be warned. The VU meter is not an alternative, since it has a delay.

An an other minor reason, is that we will loose the visual symmetry when displayed in a row with the master vu-meter and clipping light.

mixxxbot commented 2 years ago

Commented by: ywwg Date: 2015-03-01T02:35:29Z

maybe in the mode I talk about the clipping light can be yellow :). Anyway for now I agree, we should keep them.