mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.55k stars 1.29k forks source link

Insert effects via JACK #7889

Open mixxxbot opened 2 years ago

mixxxbot commented 2 years ago

Reported by: fallenblood Date: 2015-03-10T17:56:54Z Status: Confirmed Importance: Wishlist Launchpad Issue: lp1430464 Tags: effects, jack


Mixxx already has separate outputs for each deck, as well as Aux inputs (which I couldn't quite figure out how they work but I assume they allow you to feed external inputs into the application's mixer). However, last time I tried this still did not allow me to run the signal from a deck through external software FX (such as a Carla rack) and back into the mixer. Is there any way to get that behavior with the current development version of Mixx, or are there any plans to make it possible?

mixxxbot commented 2 years ago

Commented by: Be-ing Date: 2015-03-12T13:34:56Z


I think this should be implemented in a way that does not require involving Mixxx's auxiliary inputs. There should be a straightforward interface in Mixxx for setting a deck to send its signal to a JACK sink and back to Mixxx. Mixxx would automatically create a new JACK sink for the deck when this feature is used.

mixxxbot commented 2 years ago

Commented by: daschuer Date: 2015-03-12T15:40:50Z


This bug is somehow blocked by this: Bug #⁠1172299 Mixxx needs to become a native Jack client

Also related: Bug #⁠1097070 Bug #⁠1370837 www.mixxx.org/wiki/doku.php/extending_the_effects_engine_report_w7 http://www.mixxx.org/forums/viewtopic.php?f=1&t=6590&p=22616&hilit=send+effect#p22616

mixxxbot commented 2 years ago

Commented by: ywwg Date: 2015-03-12T17:21:21Z


It's most likely that this bug will get fixed when Mixxx gets support for effects plugins like LADSPA.

mixxxbot commented 2 years ago

Commented by: daschuer Date: 2015-03-12T18:42:29Z


Probably not, because we have already a LV2 (LADSPA successor) branch without a Jack interface https://github.com/mixxxdj/mixxx/pull/359. So if one like to adopt this, fix Bug #⁠1172299 and then introduce an Effect that routs to Jack.

mixxxbot commented 2 years ago

Commented by: ywwg Date: 2015-03-12T19:35:56Z


What I meant is, we probably won't do this, instead focusing on bringing effects into mixxx rather than piping audio out to other applications.

mixxxbot commented 2 years ago

Commented by: Be-ing Date: 2017-12-28T04:24:13Z


As discussed in https://github.com/mixxxdj/mixxx/pull/1254#issuecomment-346853954 , external software effects would be supported much better by implementing support for plugin formats designed for this purpose such as LV2 (Bug #⁠1530238) and VST (Bug #⁠1740335). We cannot use Mixxx's controller mapping system to interface with separate programs in a reliable and intuitive way, but we can do that with effect plugins.

As for send/return loops with hardware effects, that is not technically possible because our effect units have switchable inputs and a hardware send/return loop introduces more latency. The extra latency could only be compensated for to keep all channels aligned if the signal path was fixed. Switching the latency of a signal path during playback would create brief gaps of silence and the signal path with added latency would be misaligned in time with the other channels.

mixxxbot commented 2 years ago

Commented by: daschuer Date: 2017-12-28T09:55:49Z


We should still consider this use case together with the send / return feature. https://bugs.launchpad.net/mixxx/+bug/1097070