search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.45k stars 1.27k forks source link

LateNight: toggling big library view sometimes focuses search bar when small library display is showing #8079

Closed mixxxbot closed 2 years ago

mixxxbot commented 2 years ago

Reported by: Be-ing Date: 2015-06-04T18:59:25Z Status: Fix Released Importance: Low Launchpad Issue: lp1462061 Tags: keyboard, skin, usability

Upon toggling the big library view either on or off, sometimes the search bar is focused. When using the space bar rather than a controller to do this, it is particularly annoying because a space is entered into the search bar if it is not unfocused before pressing the space bar again, which causes Mixxx to forget the selected track because a new search term is entered (see also: bug 1462074). This only occurs with the small library display showing; when the small library display is hidden, toggling the big library view works as expected without affecting the search bar.
mixxxbot commented 2 years ago

Commented by: esbrandt Date: 2015-06-04T19:08:06Z

Related lp:1449888

mixxxbot commented 2 years ago

Commented by: Be-ing Date: 2015-06-05T03:33:28Z

Upon further testing, I cannot reproduce this every time. I cannot figure out exactly when it happens and when it does not.

mixxxbot commented 2 years ago

Commented by: Be-ing Date: 2015-07-07T20:15:52Z

Can anyone reproduce this? It's quite an annoying interruption of workflow.

mixxxbot commented 2 years ago

Commented by: rafvdm Date: 2015-07-09T06:04:42Z

See also post https://bugs.launchpad.net/bugs/1472705.

That was Windows 7 Home Premium 64 bit. In the meantime I installed build 1.12-r5481 on Ubuntu 14.04 LTS 64 bit. Same problem.

I seem to encounter this EVERY TIME. But as I described in the mentioned post, I notice this only when the focus is on the track list. Not if it is in the sidebar.

@Be: What do you mean with the "small library display" and the "big library view"?

I also confirm it seems to be skin related. It tried Deere and Shade and didn't notice the issue. Only happens in the LateNight skin.

Little hint ... but this is NOT a solution ... : When focus is on the search box, the quickest way to change it to the track list is by hitting the ESC-key.

mixxxbot commented 2 years ago

Commented by: Be-ing Date: 2015-07-09T06:21:21Z

@Be: What do you mean with the "small library display" and the "big library view"?

"Big library view" = library maximized, taking whole Mixxx window "small library display" = library not maximized, taking only bottom of Mixxx window

mixxxbot commented 2 years ago

Commented by: rafvdm Date: 2015-07-09T15:07:38Z

When I hit space

With me it always acts the same no matter if I am in "small library display" or "big library view". And it acts like that at each instant!

@Be: for the reproduction ... can you give me a sequence of actions where you expect it to fail, but it works OK? I will try and see how it functions on my machines.

mixxxbot commented 2 years ago

Commented by: Be-ing Date: 2015-07-09T18:06:24Z

When I click the "Library" button without the library maximized to hide the library, then press space or the button I've mapped on my controller to maximize_library, it works as expected.

mixxxbot commented 2 years ago

Commented by: rafvdm Date: 2015-07-15T15:37:18Z

I think Be and I are currently poorly communicating ;-) , but I think I get the idea.

I notice that when hiding, then showing the library by the button, focus is totally gone. You can check that by pressing the down arrow key. Nothing moves.

So I still think the bad space bar behaviour could be related to focus. As if focus gets to the track list only when it formerly was on the sidebar. If the library is hidden and one presses space, the library pops up but focus is not on the sidebar, making it go to the search box.

I rephrase what I mentioned above:

When I hit space

@Be: Do you agree?

I somewhat have the feeling that the solution is not more complex than ...

Or do I miss something?

mixxxbot commented 2 years ago

Commented by: rafvdm Date: 2015-07-15T15:38:26Z

Read sideBOX as sideBAR of course :-)

mixxxbot commented 2 years ago

Commented by: Be-ing Date: 2015-07-16T00:01:24Z

The search bar is focused for me regardless of where the focus was before.

mixxxbot commented 2 years ago

Commented by: Be-ing Date: 2015-07-22T18:05:28Z

Does anyone have an idea what's going wrong here?

mixxxbot commented 2 years ago

Commented by: ferranpujolcamins Date: 2015-07-23T19:53:35Z

Assigneds to me because I'm going to investigate this :)

mixxxbot commented 2 years ago

Commented by: Be-ing Date: 2015-07-24T21:53:43Z

Thank you for looking into this.

mixxxbot commented 2 years ago

Commented by: ferranpujolcamins Date: 2015-07-30T19:02:17Z

Do you know how does QT handle focus when a widget is hidden?

mixxxbot commented 2 years ago

Commented by: ferranpujolcamins Date: 2015-07-30T21:11:18Z

Ok, the problem has to do with the Library widget being a singleton. If I modify LateNight so that the library is not a singleton, the problem disappears.

What does exactly happens when a singleton widget is hidden and shown in another place?

mixxxbot commented 2 years ago

Commented by: rafvdm Date: 2015-09-30T17:18:47Z

Is not fixed.

Acer Aspire 7750 CPU: Intel(R) Core(TM) i5-2410M 2.30GHz Memory: 4GB RAM OS: Windows 7 64bit Build: mixxx-1.12.0-beta1-1.12-git5554-release-x64.exe

When maximizing the library using the space bar, the cursor seems not to move to the search box, but it acts like it does. Click once on a track in the maximized library. Either ...

  1. Hit space again to restore the window -> the search text disappears. Or ...
  2. Press the down arrow -> you're going down in the sidebar instead of the track list.
mixxxbot commented 2 years ago

Commented by: ferranpujolcamins Date: 2015-10-03T16:16:16Z

I can reproduce the first problem but not the second.

mixxxbot commented 2 years ago

Commented by: ronso0 Date: 2018-03-23T12:22:05Z

this seems to be fixed (ubuntu 14.04, xfce4) in all skins, therefore I doubt this has to do with my rework of LateNight.

But while checking this, I noticed oly Tango has that useful Library focus indicator. https://bugs.launchpad.net/mixxx/+bug/1758319

mixxxbot commented 2 years ago

Issue closed with status Fix Released.