If a connection to a streaming server fails, the [Shoutcast],status CO remains in wrong status, potentially displaying a misleading icon

[mixxxbot]

Reported by: esbrandt Date: 2015-11-28T12:17:19Z Status: Fix Released Importance: Low Launchpad Issue: lp1520768 Tags: broadcast

---

Latest 2.0.0-rc1

The following PR adds a status indicator for the live broadcasting feature: https://github.com/mixxxdj/mixxx/pull/665/files https://bugs.launchpad.net/mixxx/+bug/1101329/comments/2

If you try to connect to a streaming server and the connection failed, the [Shoutcast],status control remains at the failure status, while it should return to the unconnected status when clicking away the obligatory modal window. This can be observed best with the Shade skin, where you always have the failureicon below the clock, after the first unsuccessful attempt to start live broadcasting.

I`d expect the following:

• Connect to the streaming server
• Error occurs -> [Shoutcast],status changes to failure and the password/connection hint modal window appears.
• Click away modal window -> [Shoutcast],status resets to default unconnected

[mixxxbot]

Commented by: daschuer Date: 2015-11-28T20:12:21Z

---

This behaviour is by design. I think it is correct to show the failureicon until you connect successful live broadcasting works as desired. The configuration / connection was proven as wrong / failure. Keeping the failure until proving the opposite seems to be not bad.

IMHO with the proposed behaviour the failure icon is redundant, since the pop up is displayed at the same time anyway.

[mixxxbot]

Commented by: esbrandt Date: 2015-11-29T07:29:53Z

---

The attempt to connect was not successful -> We notify the user about the failure (modal + icon), and about the possible reason (modal). User is notified that action has to be taken, and confirms modal box. We are back in the unconnected state. End of interaction.

Why bother with an failure message afterwards, even if its an icon? This would be exclusive to other error notifications in the application.

[mixxxbot]

Commented by: rryan Date: 2015-12-31T18:17:47Z

---

Did this get fixed? https://github.com/mixxxdj/mixxx/pull/665

[mixxxbot]

Commented by: rryan Date: 2015-12-31T18:17:59Z

---

(in mixxx 2.0)

[mixxxbot]

Commented by: rryan Date: 2015-12-31T18:20:01Z

---

BTW I agree with Jus in post 2 -- for reliability Mixxx should behave like a state machine from a user's mental model perspective.

[mixxxbot]

Commented by: rryan Date: 2015-12-31T18:20:27Z

---

Nevermind -- the bug was filed after the PR was merged :)

[mixxxbot]

Commented by: Be-ing Date: 2017-11-12T16:45:09Z

---

Does https://github.com/mixxxdj/mixxx/pull/1300 fix this?

[mixxxbot]

Commented by: daschuer Date: 2017-11-13T00:07:51Z

---

We can consider this bug again after it is merged. The state icon should work as expected, but I do not agree with the original bug as outlined in #⁠1.

[mixxxbot]

Commented by: rryan Date: 2018-09-21T19:20:09Z

---

Is this still an issue? PR #⁠1300 has merged.

[mixxxbot]

Commented by: ronso0 Date: 2021-10-29T10:21:44Z

---

Fixed by https://github.com/mixxxdj/mixxx/pull/4001 in 2.3

[mixxxbot]

Issue closed with status Fix Released.