search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.52k stars 1.28k forks source link

Loop_move_XX_forward & scratching disables Loop #8824

Closed mixxxbot closed 2 years ago

mixxxbot commented 2 years ago

Reported by: ronso0 Date: 2017-03-02T16:19:36Z Status: Fix Released Importance: Medium Launchpad Issue: lp1669500

I experience that loop_move_xx_forward exits the loop if moved over loop_out boundary.

Same happens when scratching backwards over loop_in, which I do after setting a loop and then scratching until I find the right point to drop it.

Reproduce: 1 load a track 2 play, set up a loop 3 scratch backwards over loop_in

play position jumps to loop_out loop is disabled

6112 built from source 6359 faad=1 ffmpeg=0 6359 faad=0 ffmpeg=1 6359 faad=0 ffmpeg=0

might be related to Bug 1475442

mixxxbot commented 2 years ago

Commented by: ronso0 Date: 2017-10-13T07:36:45Z

I tested again, this behavior occurs very unpredictably. Sometimes scratching works perfectly when loading a track the first time in a session, but with same track reloaded later on, it would fail.

mixxxbot commented 2 years ago

Commented by: ronso0 Date: 2017-10-13T07:37:17Z

Also it seems to be codec dependent. I discoverd a .wma which always works.

6359 faad=0 ffmpeg=1

mixxxbot commented 2 years ago

Commented by: ronso0 Date: 2017-10-13T10:16:46Z

I tried [WiP] Universal SoundSource based on FFmpeg 3.1 (and beyond) https://github.com/mixxxdj/mixxx/pull/1356 and appearantly it's fixed for some mp3 and wav files that fail with master.

mixxxbot commented 2 years ago

Commented by: daschuer Date: 2017-11-01T21:36:28Z

A possible fix is in: https://github.com/mixxxdj/mixxx/pull/1367

I have found a rounding issue when playing at fast rates. OTOH this does not explain why it is fixes with FFmpeg 3.1

Maybe you see a different issue?

mixxxbot commented 2 years ago

Issue closed with status Fix Released.