search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.53k stars 1.28k forks source link

fader activation for echo effect #8895

Open mixxxbot opened 2 years ago

mixxxbot commented 2 years ago

Reported by: Be-ing Date: 2017-06-30T15:26:43Z Status: Confirmed Importance: Wishlist Launchpad Issue: lp1701632 Tags: effects

The Pioneer DJM 909 hardware mixer has a neat feature on its echo effect. When lowering a volume fader to let the post-fader echo effect play its echo buffer, the output of the effect is activated by lowering the fader. The DJ does not need to think about manipulating the dry/wet knob, they only need to lower the fader. It would be useful to add this as a binary button parameter for the echo effect. Implementing this will require making the state of the channel fader accessible as a feature on the GroupFeatureState passed to the effect.

Here is a video demonstrating the effect: https://www.youtube.com/watch?v=352bAB_Pjgg

mixxxbot commented 2 years ago

Commented by: Be-ing Date: 2017-06-30T15:27:26Z

Related: Bug #⁠1370837

mixxxbot commented 2 years ago

Commented by: esbrandt Date: 2017-07-01T09:11:30Z

If implemented, paves way for lp:661917

mixxxbot commented 2 years ago

Commented by: Be-ing Date: 2017-07-02T19:24:01Z

I started working on this and realized it would be pretty complicated to implement well. If the Echo effect does not output when the fader is up, there is a sudden jump when raising the fader to the top. I'm not sure how to work around that.