mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.45k stars 1.27k forks source link

skin text is not translatable #8965

Open mixxxbot opened 2 years ago

mixxxbot commented 2 years ago

Reported by: Be-ing Date: 2017-11-11T16:28:51Z Status: Confirmed Importance: High Launchpad Issue: lp1731653


We now have lots of text labels in skins. These need to use translatable strings. The WPushButton and WLabel widgets need to be modified to handle this.

mixxxbot commented 2 years ago

Commented by: ronso0 Date: 2017-11-11T18:01:50Z


I partly agree this is a bug: Yes: for the skin settings menus in Deere and Tango No: most buttons in skin itself I don't agree it's high priority.

If we make labels like "head gain" translatable, i.e. the french translation will never fit the button and therefor require eliding (right? center?) which will look messy IMO

One reason for me to prefer icons over text in Tango was that they are multilingual (maybe even multicultural since DJs across the globe share international equipment) and they require less space in 99,9%. Take a look at Tango's HeadSplit buttons for example. Can't we come up with equally distinct icons for other buttons/knobs as well instead of implementing the translation engine for buttons and also fix all skins for 2.1?

mixxxbot commented 2 years ago

Commented by: Be-ing Date: 2017-11-11T18:17:10Z


I agree that buttons are preferable to text outside of the skin settings menu. Graphic design is not one of my strengths, but if you'd like to make icons to replace text in Deere, that would be welcome.

mixxxbot commented 2 years ago

Commented by: Be-ing Date: 2017-11-12T19:18:16Z


Moving this back to High priority because it has to be fixed before string freeze.

mixxxbot commented 2 years ago

Commented by: Be-ing Date: 2017-12-11T06:26:02Z


I'm not sure it is feasible to implement this and finish everything else before the 2.1 beta release. Is using icons where possible good enough for 2.1? That should leave most text in skins in the skin settings menus.

mixxxbot commented 2 years ago

Commented by: ronso0 Date: 2019-12-09T17:31:25Z


When we agree this affects the skin settiings menu only, a separate skin settings widget would solve the issue for me.

"Move Skin menu to a pop up / slide over menu" https://bugs.launchpad.net/mixxx/+bug/1765926

mixxxbot commented 2 years ago

Commented by: Be-ing Date: 2019-12-09T17:43:51Z


There is more text in the skins than just the skin settings menus. So that wouldn't fully solve the problem.

mixxxbot commented 2 years ago

Commented by: ronso0 Date: 2019-12-09T18:21:03Z


I'm not sure what you refer to:

What else did I miss?